Bug #82880

Synchronize inline records triggers maxItemsError

Added by Nicole Cordes about 1 year ago. Updated 5 months ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
Start date:
2017-10-29
Due date:
% Done:

0%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

How to reproduce:

1. Install attached extension.
2. Add new page.
3. Insert "Container" record on the created page.
3.1 Add two content records to "Container" field.
4. Translate the page to another language.
5. Translate the content element with "Translate" mode.
6. Open the container element in default language and attach a third inline content element.
7. Open the translated container element. You will see the third inline content element without translation.
8. Synchronize translated records with "Synchronize with original language"

Expected result:

I see three translated content records.

Actual result:

I see only two content elements afterwards. An error "A maximum of 3 child records are allowed." is triggered. Reloading the page however shows the expected records.

Guess:

I think the error is triggered before the untranslated record is removed. Thus the JavaScript prevents add the new (translated) content record. It seems the PHP-part of the localization works without errors.

test_container_0.1.0_201710291345.zip (14.8 KB) Nicole Cordes, 2017-10-29 13:53


Related issues

Related to TYPO3 Core - Bug #80036: FAL translation with TCA maxitems set New 2017-02-27

History

#1 Updated by Andreas Wolf about 1 year ago

  • Status changed from New to Accepted

After investigation, I found out that this is indeed a pure JS issue:

  • memorizeAddRecord() adds the new element’s ID to the hidden field value, after which isBelowMax() will return false => this is required to remove the control buttons above/below the record list
  • domAddNewRecord() is called afterwards, to add the record to the list. Unfortunately, this also uses isBelowMax() to check if the limits have been exceeded. This fails because the hidden field value was extended in the previous call

Unlike I initially suspected, this is in no way related to the placeholder, as far as I can see.

IMO, the best fix for this would be to change isBelowMax and the code that writes to the hidden field to use the actually present records, as these are the source of truth in this case. This would require us to add the record UIDs to the rendered record HTML, but that is really simple, and change the code accordingly. I'm unsure if this would have any additional impact.

#2 Updated by Gerrit Code Review about 1 year ago

  • Status changed from Accepted to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54521

#3 Updated by Susanne Moog about 1 year ago

  • Category set to DataHandler aka TCEmain

#4 Updated by Oliver Hader 9 months ago

  • Category changed from DataHandler aka TCEmain to FormEngine aka TCEforms

#5 Updated by Gerrit Code Review 7 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54521

#6 Updated by Peter Rauber 5 months ago

Any news when the fix will be released?

#7 Updated by Riccardo De Contardi 5 months ago

  • Related to Bug #80036: FAL translation with TCA maxitems set added

Also available in: Atom PDF