Bug #82881

Story #69617: FormEngine bugs

Wrong page uid given to getDefaultUploadFolder for InlineControlContainer

Added by Torben Hansen almost 2 years ago. Updated 6 months ago.

Status:
New
Priority:
Should have
Assignee:
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2017-10-29
Due date:
% Done:

0%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When a user adds a media element to a page object, the function getDefaultUploadFolder should get the page UID of the current page as an argument instead of the UID of the parent page.

See: [[https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php#L488]]

For all other scenarios (e.g. tt_content, extbase records with file relations), this works fine. Only for file relations on pages, the wrong PID is passed.

The page uid is only used in the hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_userauthgroup.php']['getDefaultUploadFolder']. The bug may lead to unexpected behaviour, if you want to configure the default upload folder on page uid basis.

History

#1 Updated by Frans Saris almost 2 years ago

Tnx for digging into this. This is only incorrect for page records. Not for other records correct?

Could you push a patch to adjust this to our review system?

Frans

#2 Updated by Torben Hansen almost 2 years ago

  • Assignee set to Torben Hansen

Yes, this seems only to be wrong for inline elements on a page. All other records (e.g. news, tt_content, sys_file_collection) works.

I will create a patch for the change.

#3 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54513

#4 Updated by Christian Kuhn over 1 year ago

  • Parent task set to #69617

#5 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54513

#6 Updated by Christian Kuhn 11 months ago

  • Status changed from Under Review to New

#7 Updated by Susanne Moog 6 months ago

  • Category changed from File Abstraction Layer (FAL) to FormEngine aka TCEforms

Also available in: Atom PDF