Bug #83328

Wrong result with QueryGenerator->getTreeList()

Added by Florian Rival over 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend API
Target version:
-
Start date:
2017-12-14
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When retrieving tree list with QueryGenerator->getTreeList(), the result is often wrong.

Example with following tree :

A
!-> B > D
!
!
> C -> E

$queryGenerator->getTreeList(#pid-A, 3, 0);

Result : A, B, C, D, E (OK)

$queryGenerator->getTreeList(#pid-A, 3, 1);

Result : B, E instead of B, C, D, E

$queryGenerator->getTreeList(#pid-A, 3, 2);

Empty result instead of D, E

The problem is because when concatenated pid, a comma is missing.


Files

bug_83328.diff (780 Bytes) bug_83328.diff Florian Rival, 2017-12-14 16:15

Related issues

Related to TYPO3 Core - Task #85024: Add functional tests for QueryGeneratorTestClosedAlexander Schnitzler2018-05-16

Actions
#1

Updated by Florian Rival over 3 years ago

  • Description updated (diff)
#2

Updated by Florian Rival over 3 years ago

The patch to correct this problem.

#3

Updated by Susanne Moog over 3 years ago

  • Category set to Backend API
#4

Updated by Marieke de Bruin over 3 years ago

This bug is also present in CMS7

#5

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56139

#6

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56139

#7

Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56139

#8

Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56139

#9

Updated by Gerrit Code Review over 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56139

#10

Updated by Gerrit Code Review over 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56139

#11

Updated by Gerrit Code Review over 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56139

#12

Updated by Gerrit Code Review over 3 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56139

#13

Updated by Gerrit Code Review over 3 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56139

#14

Updated by Gerrit Code Review about 3 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56139

#15

Updated by Tymoteusz Motylewski about 3 years ago

Is there an easy way to reproduce the issue from the backend?

#16

Updated by Florian Rival about 3 years ago

I don't know if there's an easy way to reproduce this bug from the backend.

#17

Updated by Guido Schmechel about 3 years ago

There is no easy way. My steps:

  • Build a small rootline in the backend
  • Build or use an extension which calls getTreeList() standalone
#18

Updated by Alexander Schnitzler about 3 years ago

  • Related to Task #85024: Add functional tests for QueryGeneratorTest added
#19

Updated by Gerrit Code Review about 3 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56139

#20

Updated by Gerrit Code Review about 3 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56984

#21

Updated by Guido S. about 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#22

Updated by Gerrit Code Review about 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57026

#23

Updated by Guido S. about 3 years ago

  • Status changed from Under Review to Resolved
#24

Updated by Benni Mack almost 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF