Bug #83328

Wrong result with QueryGenerator->getTreeList()

Added by Florian Rival almost 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend API
Target version:
-
Start date:
2017-12-14
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When retrieving tree list with QueryGenerator->getTreeList(), the result is often wrong.

Example with following tree :

A
!-> B -> D
!
!-> C -> E

$queryGenerator->getTreeList(#pid-A, 3, 0);

Result : A, B, C, D, E (OK)

$queryGenerator->getTreeList(#pid-A, 3, 1);

Result : B, E instead of B, C, D, E

$queryGenerator->getTreeList(#pid-A, 3, 2);

Empty result instead of D, E

The problem is because when concatenated pid, a comma is missing.

bug_83328.diff View (780 Bytes) Florian Rival, 2017-12-14 16:15


Related issues

Related to TYPO3 Core - Task #85024: Add functional tests for QueryGeneratorTest Closed 2018-05-16

Associated revisions

Revision b2ebd754 (diff)
Added by Guido S. over 1 year ago

[BUGFIX] getTreeList must return comma-separated list

While retrieving the list with begin as argument for a
recursive call, getTreeList builds the comma-separated list
correctly.

Resolves: #83328
Releases: master, 8.7, 7.6
Change-Id: I643477dd5c0cbfb67532dd96eb0b479e0cb532b8
Reviewed-on: https://review.typo3.org/56139
Tested-by: TYPO3com <>
Reviewed-by: Alexander Schnitzler <>
Tested-by: Alexander Schnitzler <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Frans Saris <>
Tested-by: Frans Saris <>

Revision ae609b91 (diff)
Added by Guido S. over 1 year ago

[BUGFIX] getTreeList must return comma-separated list

While retrieving the list with begin as argument for a
recursive call, getTreeList builds the comma-separated list
correctly.

Resolves: #83328
Releases: master, 8.7, 7.6
Change-Id: I643477dd5c0cbfb67532dd96eb0b479e0cb532b8
Reviewed-on: https://review.typo3.org/56984
Tested-by: TYPO3com <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision ff2bb98e (diff)
Added by Guido S. over 1 year ago

[BUGFIX] getTreeList must return comma-separated list

While retrieving the list with begin as argument for a
recursive call, getTreeList builds the comma-separated list
correctly.

Resolves: #83328
Releases: master, 8.7, 7.6
Change-Id: I643477dd5c0cbfb67532dd96eb0b479e0cb532b8
Reviewed-on: https://review.typo3.org/57026
Tested-by: TYPO3com <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Florian Rival almost 2 years ago

  • Description updated (diff)

#2 Updated by Florian Rival almost 2 years ago

The patch to correct this problem.

#3 Updated by Susanne Moog almost 2 years ago

  • Category set to Backend API

#4 Updated by Marieke de Bruin over 1 year ago

This bug is also present in CMS7

#5 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56139

#6 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56139

#7 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56139

#8 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56139

#9 Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56139

#10 Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56139

#11 Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56139

#12 Updated by Gerrit Code Review over 1 year ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56139

#13 Updated by Gerrit Code Review over 1 year ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56139

#14 Updated by Gerrit Code Review over 1 year ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56139

#15 Updated by Tymoteusz Motylewski over 1 year ago

Is there an easy way to reproduce the issue from the backend?

#16 Updated by Florian Rival over 1 year ago

I don't know if there's an easy way to reproduce this bug from the backend.

#17 Updated by Guido Schmechel over 1 year ago

There is no easy way. My steps:

  • Build a small rootline in the backend
  • Build or use an extension which calls getTreeList() standalone

#18 Updated by Alexander Schnitzler over 1 year ago

  • Related to Task #85024: Add functional tests for QueryGeneratorTest added

#19 Updated by Gerrit Code Review over 1 year ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56139

#20 Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56984

#21 Updated by Guido S. over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#22 Updated by Gerrit Code Review over 1 year ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57026

#23 Updated by Guido S. over 1 year ago

  • Status changed from Under Review to Resolved

#24 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF