Bug #83425
closedCustom validators
100%
Description
Parsing goes wrong in case of @validate in combination with a custom validator. The problem is that the $ sign gets stripped (in tags), resulting in a failure of the parseValidatorAnnotation function in TYPO3/CMS/Extbase/Classes/Validation/ValidatorResolver.php. The function is called from the new getMethodValidateAnnotations in the same class.
Apparently this function still uses the tags and not the new annotations approach. The validators array annotations/contains the correct value.
If I dump the ClassSchema I see the following:
[tags] => Array ( [param] => Array ( [0] => \FraJaWeB\FwCore\Domain\Model\User $user [1] => string $username ) [validate] => Array ( [0] => user \FraJaWeB\FwCore\Domain\Validator\User2Validator ) ) [annotations] => Array ( [validators] => Array ( [0] => $user \FraJaWeB\FwCore\Domain\Validator\User2Validator ) )
Updated by Georg Ringer about 7 years ago
- Related to Epic #82703: Introduce doctrine/annotations to replace user defined annotations (mostly in Extbase) added
Updated by Georg Ringer about 7 years ago
- Related to Feature #83167: Replace @validate with @Extbase\Validate added
Updated by Gerrit Code Review about 7 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55244
Updated by Gerrit Code Review about 7 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55244
Updated by Gerrit Code Review about 7 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55244
Updated by Gerrit Code Review about 7 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55244
Updated by Gerrit Code Review about 7 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55244
Updated by Gerrit Code Review about 7 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55244
Updated by Anonymous about 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 80e78c98e901be7433d094bd632f4abce67c950b.