Project

General

Profile

Actions
Copy link

Bug #83477

closed

Form finisher parseOption fails with MultiCheckbox / MultiSelect

Added by Ronald Kools almost 7 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Ronald Kools
Category:
Form Framework
Target version:
-
Start date:
2018-01-04
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.0
Tags:
Form Framework, finisher, array
Complexity:
Is Regression:
Sprint Focus:
Remote Sprint

Description

I have a form with a field called "newsletter", which enables you to select 1 or more newsletters using a MultiCheckbox.

However, when you use parseOption on this field the values - that are actually correcty retrieved in $value before the if-statement below is executed - are discarded because $value is only allowed as a string or numeric value:

Line 208:

if (!is_string($value) && !is_numeric($value)) {
$value = '{' . $match[1] . '}';
}

I would expect that it would be returning an array of parsed options instead of '{newsletter}'.

Files

Download all files
newsletter.yaml (996 Bytes) newsletter.yaml Ronald Kools, 2018-03-14 16:02
newsletter.jpg (74.7 KB) newsletter.jpg Ronald Kools, 2018-03-14 16:02

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Bug #84698: Severity for ext:form was not acceptedClosed2018-04-12

Actions
Actions
Copy link
 #1

Updated by Björn Jacob almost 7 years ago

  • Sprint Focus set to Remote Sprint
Actions
Copy link
 #2

Updated by Gerrit Code Review almost 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55820

Actions
Copy link
 #3

Updated by Gerrit Code Review almost 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55820

Actions
Copy link
 #4

Updated by Gerrit Code Review almost 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55820

Actions
Copy link
 #5

Updated by Gerrit Code Review almost 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55820

Actions
Copy link
 #6

Updated by Oliver Hader almost 7 years ago

Ronald: Can you please provide the @options YAML configuration of the finisher you're using? Thanks in advance!

I'm currently trying to understand, whether $optionValue is an array in this scenario or the result of retrieving form state data with ObjectAccess::getPropertyPath is the issue here.

Actions
Copy link
 #7

Updated by Gerrit Code Review over 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55820

Actions
Copy link
 #8

Updated by Gerrit Code Review over 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55820

Actions
Copy link
 #9

Updated by Gerrit Code Review over 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55820

Actions
Copy link
 #10

Updated by Gerrit Code Review over 6 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55820

Actions
Copy link
 #11

Updated by Gerrit Code Review over 6 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55820

Actions
Copy link
 #12

Updated by Gerrit Code Review over 6 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55820

Actions
Copy link
 #13

Updated by Gerrit Code Review over 6 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55820

Actions
Copy link
 #14

Updated by Gerrit Code Review over 6 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55820

Actions
Copy link
 #15

Updated by Gerrit Code Review over 6 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55820

Actions
Copy link
 #16

Updated by Gerrit Code Review over 6 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55820

Actions
Copy link
 #17

Updated by Ronald Kools over 6 years ago

Oliver Hader wrote:

Ronald: Can you please provide the @options YAML configuration of the finisher you're using? Thanks in advance!

I'm currently trying to understand, whether $optionValue is an array in this scenario or the result of retrieving form state data with ObjectAccess::getPropertyPath is the issue here.

Oliver, sorry for my slow reply, I only just noticed your request. As it is already patched, do you still need it?

Actions
Copy link
 #18

Updated by Björn Jacob over 6 years ago

  • Assignee set to Ronald Kools
  • Priority changed from -- undefined -- to Must have

The patch has not been merged yet. It is still under review. Please provide your YAML. That would be grand.

Actions
Copy link Download all files
 #19

Updated by Ronald Kools over 6 years ago

Bjoern Jacob wrote:

The patch has not been merged yet. It is still under review. Please provide your YAML. That would be grand.

Done!

I attached both a screenshot from the backend and the yaml. If you need anything else please let me know. ;-)

Actions
Copy link
 #20

Updated by Gerrit Code Review over 6 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55820

Actions
Copy link
 #21

Updated by Gerrit Code Review over 6 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55820

Actions
Copy link
 #22

Updated by Gerrit Code Review over 6 years ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55820

Actions
Copy link
 #23

Updated by Gerrit Code Review over 6 years ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55820

Actions
Copy link
 #24

Updated by Oliver Hader over 6 years ago

  • Related to Bug #84698: Severity for ext:form was not accepted added
Actions
Copy link
 #25

Updated by Gerrit Code Review over 6 years ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55820

Actions
Copy link
 #26

Updated by Gerrit Code Review over 6 years ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55820

Actions
Copy link
 #27

Updated by Gerrit Code Review over 6 years ago

Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55820

Actions
Copy link
 #28

Updated by Gerrit Code Review over 6 years ago

Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55820

Actions
Copy link
 #29

Updated by Ralf Zimmermann over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #30

Updated by Gerrit Code Review over 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56722

Actions
Copy link
 #31

Updated by Ralf Zimmermann over 6 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #32

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF