Bug #83502

YAML files not managed through FAL - can be deleted via file list

Added by Christian Rieke 6 months ago. Updated 4 months ago.

Status:
Resolved
Priority:
Should have
Category:
Form Framework
Target version:
-
Start date:
2018-01-07
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:
Remote Sprint

Description

One of the main advantages of FAL is that files that are in use in the FE are protected against accidental deletion by BE users. This is not true for form.yaml files.

This is a bug, not a feature request.

If a user has the right to create/edit forms, the corresponding .yaml file is created in the file storage, to which the user must by definition have read/write access. Since .yaml files are not controlled through FAL, the user can delete these files without the typical FAL protection (e.g. "The file cannot be deleted since it is still used at the following places: [record:tt_content:XYZ]" error). In addition, files with/without FAL management are now stored in the same storage structure. Users used to FAL will not think twice about deleting files without FAL references, as those apparently are not used in the FE.


Related issues

Related to TYPO3 Core - Bug #83991: Deletion test in form module is case insensitive Closed 2018-02-21

Associated revisions

Revision 2dd7f853 (diff)
Added by Ralf Zimmermann 4 months ago

[BUGFIX] Use sys_file as soft reference for formDefinitions

Register an embedded form definition as sys_file soft reference to show
the usage of the form definition within the file list module.

Resolves: #83502
Releases: master, 8.7
Change-Id: Ifdba760b8ebd45a9b83e97c5a20cf23ede6a74d7
Reviewed-on: https://review.typo3.org/55830
Tested-by: TYPO3com <>
Reviewed-by: Frans Saris <>
Tested-by: Frans Saris <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision 514d1ff4 (diff)
Added by Ralf Zimmermann 4 months ago

[BUGFIX] Use sys_file as soft reference for formDefinitions

Register an embedded form definition as sys_file soft reference to show
the usage of the form definition within the file list module.

Resolves: #83502
Releases: master, 8.7
Change-Id: Ifdba760b8ebd45a9b83e97c5a20cf23ede6a74d7
Reviewed-on: https://review.typo3.org/55843
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Frans Saris 6 months ago

Not sure if FAL is the way to go here as you can also use yaml files from extensions and those shouldn't be indexed/referenced as FAL objects. Maybe a combination of both could be used.

A reference of every used yaml file in the sys_ref would also prevent the user from deleting the files.

#2 Updated by Bjoern Jacob 5 months ago

  • Category set to Form Framework

#3 Updated by Bjoern Jacob 4 months ago

  • Related to Feature #82089: EXT:form Support "imports" in form configuration added

#4 Updated by Bjoern Jacob 4 months ago

  • Sprint Focus set to Remote Sprint

#5 Updated by Bjoern Jacob 4 months ago

This only happens in the list module. The form manager can handle this properly. Right now, we are discussing the solution of this problem.

As a first step (workaround), you could set a different folder for your forms. Please check the docs: https://docs.typo3.org/typo3cms/extensions/form/Concepts/FormFileStorages/Index.html
In TYPO3 v9 we ship a dedicated folder for form definitions.

#6 Updated by Bjoern Jacob 4 months ago

  • Subject changed from form.yaml files not managed through FAL to YAML files not managed through FAL - can be deleted via file list

#7 Updated by Bjoern Jacob 4 months ago

  • Related to deleted (Feature #82089: EXT:form Support "imports" in form configuration)

#8 Updated by Bjoern Jacob 4 months ago

  • Status changed from New to Accepted
  • Assignee set to Ralf Zimmermann

#9 Updated by Bjoern Jacob 4 months ago

  • Status changed from Accepted to In Progress

#10 Updated by Gerrit Code Review 4 months ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55830

#11 Updated by Gerrit Code Review 4 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55830

#12 Updated by Gerrit Code Review 4 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55830

#13 Updated by Gerrit Code Review 4 months ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55843

#14 Updated by Ralf Zimmermann 4 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#15 Updated by Bjoern Jacob 4 months ago

  • Related to Bug #83991: Deletion test in form module is case insensitive added

Also available in: Atom PDF