Bug #83923: TCA Linkwizard does not save New Files at the first time - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #83923

closed

TCA Linkwizard does not save New Files at the first time

Added by Paul Beck almost 7 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Backend JavaScript

Target version:

9.2

Start date:

2018-02-15

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

The link wizard of TCA fields - for example at the "header_link" field of tt_content - does not accept links to new files if you just uploaded them in the wizard.

How to reproduce:

Open a tt_content element
Open the link wizard next to header link
Switch to "File" in the wizard
Upload a new file to any folder
Select the new uploaded file
Then the wizard will close but the field head link will stay empty
Open the wizard again and select the file and it will be set as header link

Actions

Copy link

Updated by Frank Nägler over 6 years ago

Status changed from New to Accepted
Target version set to 9.2

confirmed

Actions

Copy link

Updated by Andreas Kienast over 6 years ago

The issue does not affect new files only, but any file when a new file has been uploaded.

Actions

Copy link

Updated by Steffen Kamper over 6 years ago

This is a nasty bug.
As in FormEngineLinkBrowserAdapter.checkreference the window.opener is checked, this is gone by any form action inside the Wizardwindow.
So this has to be changed completely to local var, and has to be included in each form of the Wizardwindow.

FormEngineLinkBrowserAdapter.checkReference = function() {
    var selector = 'form[name="' + LinkBrowser.parameters.formName + '"] [data-formengine-input-name="' + LinkBrowser.parameters.itemName + '"]';
    if (window.opener && window.opener.document && window.opener.document.querySelector(selector)) {
      return window.opener.document.querySelector(selector);
    } else {
      close();
    }
  };

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56592

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56595

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56596

Actions

Copy link

Updated by Andreas Fernandez over 6 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 63f70ad44e9972d451f8504a88359f5b7c72894b.

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Status changed from Resolved to Under Review

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56596

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56595

Actions

Copy link

#10

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56596

Actions

Copy link

#11

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56595

Actions

Copy link

#12