Project

General

Profile

Actions

Bug #83923

closed

TCA Linkwizard does not save New Files at the first time

Added by Paul Beck about 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend JavaScript
Target version:
Start date:
2018-02-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The link wizard of TCA fields - for example at the "header_link" field of tt_content - does not accept links to new files if you just uploaded them in the wizard.

How to reproduce:

  1. Open a tt_content element
  2. Open the link wizard next to header link
  3. Switch to "File" in the wizard
  4. Upload a new file to any folder
  5. Select the new uploaded file
  6. Then the wizard will close but the field head link will stay empty
  7. Open the wizard again and select the file and it will be set as header link
Actions #1

Updated by Frank Nägler almost 6 years ago

  • Status changed from New to Accepted
  • Target version set to 9.2

confirmed

Actions #2

Updated by Andreas Kienast almost 6 years ago

The issue does not affect new files only, but any file when a new file has been uploaded.

Actions #3

Updated by Steffen Kamper almost 6 years ago

This is a nasty bug.
As in FormEngineLinkBrowserAdapter.checkreference the window.opener is checked, this is gone by any form action inside the Wizardwindow.
So this has to be changed completely to local var, and has to be included in each form of the Wizardwindow.

FormEngineLinkBrowserAdapter.checkReference = function() {
    var selector = 'form[name="' + LinkBrowser.parameters.formName + '"] [data-formengine-input-name="' + LinkBrowser.parameters.itemName + '"]';
    if (window.opener && window.opener.document && window.opener.document.querySelector(selector)) {
      return window.opener.document.querySelector(selector);
    } else {
      close();
    }
  };
Actions #4

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56592

Actions #5

Updated by Gerrit Code Review almost 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56595

Actions #6

Updated by Gerrit Code Review almost 6 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56596

Actions #7

Updated by Andreas Fernandez almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56596

Actions #9

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56595

Actions #10

Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56596

Actions #11

Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56595

Actions #12

Updated by Andreas Fernandez almost 6 years ago

  • Status changed from Under Review to Resolved
Actions #13

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF