Bug #83923

TCA Linkwizard does not save New Files at the first time

Added by Paul Beck almost 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend JavaScript
Target version:
Start date:
2018-02-15
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The link wizard of TCA fields - for example at the "header_link" field of tt_content - does not accept links to new files if you just uploaded them in the wizard.

How to reproduce:

  1. Open a tt_content element
  2. Open the link wizard next to header link
  3. Switch to "File" in the wizard
  4. Upload a new file to any folder
  5. Select the new uploaded file
  6. Then the wizard will close but the field head link will stay empty
  7. Open the wizard again and select the file and it will be set as header link

Associated revisions

Revision 63f70ad4 (diff)
Added by Andreas Fernandez over 1 year ago

[BUGFIX] Keep parameters in link browser’s upload form

Any given attribute stored in the `P` parameter is kept and attached to
the return URL of the upload form.

Resolves: #83923
Releases: master, 8.7, 7.6
Change-Id: Id6ff93f0a30691f7bde84275128a34eb479499de
Reviewed-on: https://review.typo3.org/56592
Tested-by: TYPO3com <>
Reviewed-by: Steffen Kamper <>
Tested-by: Steffen Kamper <>
Reviewed-by: Daniel Goerz <>
Tested-by: Daniel Goerz <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision 2d26a2c0 (diff)
Added by Andreas Fernandez over 1 year ago

[BUGFIX] Keep parameters in link browser’s upload form

Any given attribute stored in the `P` parameter is kept and attached to
the return URL of the upload form.

Resolves: #83923
Releases: master, 8.7, 7.6
Change-Id: Id6ff93f0a30691f7bde84275128a34eb479499de
Reviewed-on: https://review.typo3.org/56595
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Tested-by: TYPO3com <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>

Revision a5bf5706 (diff)
Added by Andreas Fernandez over 1 year ago

[BUGFIX] Keep parameters in link browser’s upload form

Any given attribute stored in the `P` parameter is kept and attached to
the return URL of the upload form.

Resolves: #83923
Releases: master, 8.7, 7.6
Change-Id: Id6ff93f0a30691f7bde84275128a34eb479499de
Reviewed-on: https://review.typo3.org/56596
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Tested-by: TYPO3com <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>

History

#1 Updated by Frank Naegler over 1 year ago

  • Status changed from New to Accepted
  • Target version set to 9.2

confirmed

#2 Updated by Andreas Fernandez over 1 year ago

The issue does not affect new files only, but any file when a new file has been uploaded.

#3 Updated by Steffen Kamper over 1 year ago

This is a nasty bug.
As in FormEngineLinkBrowserAdapter.checkreference the window.opener is checked, this is gone by any form action inside the Wizardwindow.
So this has to be changed completely to local var, and has to be included in each form of the Wizardwindow.

FormEngineLinkBrowserAdapter.checkReference = function() {
    var selector = 'form[name="' + LinkBrowser.parameters.formName + '"] [data-formengine-input-name="' + LinkBrowser.parameters.itemName + '"]';
    if (window.opener && window.opener.document && window.opener.document.querySelector(selector)) {
      return window.opener.document.querySelector(selector);
    } else {
      close();
    }
  };

#4 Updated by Gerrit Code Review over 1 year ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56592

#5 Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56595

#6 Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56596

#7 Updated by Andreas Fernandez over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8 Updated by Gerrit Code Review over 1 year ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56596

#9 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56595

#10 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56596

#11 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56595

#12 Updated by Andreas Fernandez over 1 year ago

  • Status changed from Under Review to Resolved

#13 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF