Task #83975

Task #83888: Notice free unit tests

Notice free TcaSelectItems testing

Added by Christian Kuhn over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-02-20
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues

Related to TYPO3 Core - Bug #83980: Adjust side-effects for TcaSelectItems test cases Closed 2018-02-20
Related to TYPO3 Core - Epic #84280: Make unit tests notice free Closed 2018-03-15

Associated revisions

Revision 2845b6a3 (diff)
Added by Christian Kuhn over 1 year ago

[BUGFIX] Notice free TcaSelectItems testing

Making FormEngine data providers notice free is a mixture of
fixing notices in the test subject, and improving test setup:
  • It is assumed that stuff like BE_USER and LANG object exists,
    $subject access to these globals which throw notices is not
    fixed, instead the test setup is changed to mock these where
    needed.
  • Data provider which have dependencies to other data prodivers
    assume their data is properly set, too. In those cases the
    test setup porperly sets this dependent data.
  • Various other "real" notice fixes in test subject and code
    called by the test subject is actually fixed.

Change-Id: I7ae6444dc646ec114c15b2738ef4e30f67f88595
Resolves: #83975
Releases: master
Reviewed-on: https://review.typo3.org/55823
Reviewed-by: Mathias Schreiber <>
Tested-by: Mathias Schreiber <>
Tested-by: TYPO3com <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision eba35306 (diff)
Added by Oliver Hader over 1 year ago

[BUGFIX] Adjust side-effects for TcaSelectItems test cases

Resolves: #83980
Related: #83975
Releases: master
Change-Id: I2e8a9f3a5682644ef1dd1f3746be961a93ccafca
Reviewed-on: https://review.typo3.org/55831
Tested-by: TYPO3com <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision 813410bf (diff)
Added by Christian Kuhn over 1 year ago

[BUGFIX] Notice free FormEngine testing

Similar solutions as in issue #83975

Change-Id: I04c06f0e73f5e7d44f225ad9b60c9cbed1016308
Resolves: #83981
Related: #83975
Releases: master
Reviewed-on: https://review.typo3.org/55834
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Mathias Schreiber <>
Tested-by: Mathias Schreiber <>
Reviewed-by: Frans Saris <>
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55823

#2 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55823

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55823

#4 Updated by Christian Kuhn over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Oliver Hader over 1 year ago

  • Related to Bug #83980: Adjust side-effects for TcaSelectItems test cases added

#6 Updated by Christian Kuhn over 1 year ago

  • Related to Epic #84280: Make unit tests notice free added

#7 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF