Bug #84595
closed
EXT:form tries to get identifier from string
Added by Krzysztof Kasprzyca about 6 years ago. Updated almost 5 years ago.
100%
Description
Hello,
I think there is a problem which shouldn't exist. When I add additional configuration to EXT:form with allowedExtensionPaths pointing to folder with *.yaml forms and one of the files are empty/unable to parse I receive error page in backend module.
Message is "Call to a member function getCombinedIdentifier() on string".
Problem is in typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php line 114. Variable $file has string type so it isn't possible to retrieve file identifier
Best regards
Krzysztof Kasprzyca
Files
| trish_formtest_1.0.0.zip (2.76 KB) trish_formtest_1.0.0.zip | Simple yaml parsing test extension for this bug | Patricia Tiedemann, 2018-04-12 15:31 |
Updated by Patricia Tiedemann about 6 years ago
- Status changed from New to In Progress
- Assignee set to Patricia Tiedemann
Updated by Gerrit Code Review about 6 years ago
- Status changed from In Progress to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56640
Updated by Patricia Tiedemann about 6 years ago
- File trish_formtest_1.0.0.zip trish_formtest_1.0.0.zip added
I created a little patch to prevent this.
Added to this ticket is a simple testing extension with one working and one broken yaml form configuration.
To recreate:- Install Extension trish_formtest (creative name, I know ;)
- Page > Create new content element > Form elements
- Tab "Plugins" > Select "Form definition" should now contain "Call for papers" and "An error occured…"
Without this patch an exception will be thrown saying "Core: Exception handler (WEB): Uncaught TYPO3 Exception: Call to a member function getCombinedIdentifier() on string" whenever you try to create a form content element on any page or try to view a page or content element in the backend where this broken form was already inplemented.
Updated by Gerrit Code Review about 6 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56640
Updated by Gerrit Code Review about 6 years ago
Patch set 35 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56028
Updated by Gerrit Code Review about 6 years ago
Patch set 36 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56028
Updated by Gerrit Code Review about 6 years ago
Patch set 37 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56028
Updated by Gerrit Code Review about 6 years ago
Patch set 38 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56028
Updated by Gerrit Code Review about 6 years ago
Patch set 39 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56028
Updated by Gerrit Code Review about 6 years ago
Patch set 40 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56028
Updated by Gerrit Code Review about 6 years ago
Patch set 41 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56028
Updated by Gerrit Code Review about 6 years ago
Patch set 42 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56028
Updated by Gerrit Code Review about 6 years ago
Patch set 43 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56028
Updated by Gerrit Code Review almost 6 years ago
Patch set 44 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56028
Updated by Björn Jacob almost 6 years ago
- Sprint Focus set to On Location Sprint
Updated by Björn Jacob almost 6 years ago
- Sprint Focus changed from On Location Sprint to Remote Sprint
Updated by Björn Jacob over 5 years ago
- Status changed from Under Review to New
- Assignee deleted (
Patricia Tiedemann) - Sprint Focus deleted (
Remote Sprint)
Updated by Gerrit Code Review almost 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60598
Updated by Susanne Moog almost 5 years ago
- Assignee set to Susanne Moog
- Target version set to Candidate for patchlevel
- TYPO3 Version changed from 8 to 9
- Sprint Focus set to Remote Sprint
The original PHP error does not occur anymore, however when breaking forms on purpose the JavaScript is unable to fully load and has no editor friendly error handling. That's fixed with the patch to at least display a speaking message in case an error occurs.
Updated by Gerrit Code Review almost 5 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60598
Updated by Gerrit Code Review almost 5 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60602
Updated by Anonymous almost 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 2081a5d6efa0ab03f5a2002994d2c6e18d7b8cf1.
Updated by Benni Mack almost 5 years ago
- Status changed from Resolved to Closed