Feature #84780

Store icons fetched by the Icon API in localStorage

Added by Andreas Fernandez over 1 year ago. Updated 11 months ago.

Status:
Closed
Priority:
Should have
Category:
Backend User Interface
Target version:
Start date:
2018-04-18
Due date:
% Done:

100%

PHP Version:
Tags:
Complexity:
medium
Sprint Focus:

Description

Using the JavaScript-based Icon API has some flaws:

  • All promises created by $.ajax get stored during runtime, causing a growing memory footprint
  • Reloading the browser removes any held promise
  • To have this "cache" in place, object sharing must be done

This issue can be solved by storing the icons in the local storage of the client.


Related issues

Related to TYPO3 Core - Bug #84797: Form editor is not loading Closed 2018-04-19
Related to TYPO3 Core - Bug #84826: Finisher helper is not showing correct name of field Closed 2018-04-20
Related to TYPO3 Core - Bug #84831: localStorage icon caching breaks within the install tool Rejected 2018-04-20

Associated revisions

Revision 6f9e25d9 (diff)
Added by Andreas Fernandez over 1 year ago

[FEATURE] Store icons in localStorage

The icons that get requested by the Icon API on JavaScript side are not
stored in the client's localStorage.
To have a proper invalidation, a hash of the IconRegistry is built and
stored in the localStorage, too. If the hash changes, all icons in the
localStorage get flushed.

To achieve this, the Storage/Client module is extended to allow removing
values by a given prefix.

Resolves: #84780
Releases: master
Change-Id: Ic2137b05530201a8a94a7ea6c28ae1a012206221
Reviewed-on: https://review.typo3.org/56721
Reviewed-by: Mathias Schreiber <>
Tested-by: Mathias Schreiber <>
Tested-by: TYPO3com <>
Reviewed-by: Kay Strobach <>
Tested-by: Kay Strobach <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from In Progress to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56721

#2 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56721

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56721

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56721

#5 Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56721

#6 Updated by Andreas Fernandez over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Ralf Zimmermann over 1 year ago

  • Related to Bug #84797: Form editor is not loading added

#8 Updated by Ralf Zimmermann over 1 year ago

  • Related to Bug #84826: Finisher helper is not showing correct name of field added

#9 Updated by Ralf Zimmermann over 1 year ago

  • Related to Bug #84831: localStorage icon caching breaks within the install tool added

#10 Updated by Benni Mack 11 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF