Project

General

Profile

Actions
Copy link

Bug #84844

closed

Additional parameter(record field) needed for processTranslateTo_copyAction function

Added by Ricky Mathew over 6 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Could have
Assignee:
Ricky Mathew
Category:
Localization
Target version:
Candidate for patchlevel
Start date:
2018-04-24
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

processTranslateTo_copyAction is a nice hook for custom translation options.

It will be great to provide a fourth parameter , the 'field' parameter for this function. Because for the localisation of records, we need to know which field is passed to the hook, and then we can decide whether we need to translate that field or not.

It's simple as adding a fourth parameter to the processTranslateTo_copyAction function as follows:

$hookObj->processTranslateTo_copyAction($row[$fN], $langRec, $this, $fN);

Related issues 3 (0 open — 3 closed)

Related to TYPO3 Core - Feature #67909: Add a hook to DataHandler - localize - translateToMessageClosed2015-07-04

Actions
Related to TYPO3 Core - Epic #88027: Properly handle Hooks/Signals and EventsClosedBenni Mack2022-04-22

Actions
Has duplicate TYPO3 Core - Bug #84845: Additional parameter(record field) needed for processTranslateTo_copyAction functionRejectedBenni Mack2018-04-24

Actions
Actions
Copy link
 #1

Updated by Wouter Wolters over 6 years ago

  • Assignee deleted (Benni Mack)
  • Priority changed from Must have to Could have
  • Target version deleted (8.7.13)
Actions
Copy link
 #2

Updated by Wouter Wolters over 6 years ago

  • Has duplicate Bug #84845: Additional parameter(record field) needed for processTranslateTo_copyAction function added
Actions
Copy link
 #3

Updated by Ricky Mathew over 6 years ago

  • Status changed from New to In Progress
  • Assignee set to Ricky Mathew
Actions
Copy link
 #4

Updated by Ricky Mathew over 6 years ago

  • Target version set to 8.7.13
Actions
Copy link
 #5

Updated by Gerrit Code Review over 6 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56957

Actions
Copy link
 #6

Updated by Tymoteusz Motylewski over 6 years ago

can you please elaborate more on the use case? So I'm able to test the issue too.

Actions
Copy link
 #7

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56957

Actions
Copy link
 #8

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56957

Actions
Copy link
 #9

Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56957

Actions
Copy link
 #10

Updated by Ricky Mathew over 6 years ago

Tymoteusz Motylewski wrote:

can you please elaborate more on the use case? So I'm able to test the issue too.

Please see the commit message.

Actions
Copy link
 #11

Updated by Tymoteusz Motylewski over 6 years ago

I have read the commit message and I still don't know what is your concrete use case. Please describe it.

Actions
Copy link
 #12

Updated by Ricky Mathew over 6 years ago

Tymoteusz Motylewski wrote:

I have read the commit message and I still don't know what is your concrete use case. Please describe it.

processTranslateTo_copyAction hook helps to call thirdparty translation services.On translating contents it will be really great to know which field of a record we are translating.Say for news record the fourth parameter $fN helps to let us know whether we are translating 'Header' field or 'Teaser' field or whatever else.Based on the field there can be typoscript settings such that whether to exlcude the field from translating(without tampering tca of news record) or whatever else.So for all these usecases we just need to pass the fourth parameter $fN the record field name parameter.I hope you understood now.

Actions
Copy link
 #13

Updated by Tymoteusz Motylewski over 6 years ago

  • Related to Feature #67909: Add a hook to DataHandler - localize - translateToMessage added
Actions
Copy link
 #14

Updated by Tymoteusz Motylewski over 6 years ago

Thanks Ricky, now it's clear. I'm wondering if passing just column name is enough - how would you know from which table the field is coming from? Many tables have columns with the same name like "header".

Actions
Copy link
 #15

Updated by Ricky Mathew over 6 years ago

Tymoteusz Motylewski wrote:

Thanks Ricky, now it's clear. I'm wondering if passing just column name is enough - how would you know from which table the field is coming from? Many tables have columns with the same name like "header".

The 'cmdmap' property of third parameter($this, ie Datahandler) helps us to identify the table name.So no worries.

Actions
Copy link
 #16

Updated by Ricky Mathew over 6 years ago

  • Tracker changed from Feature to Bug
  • TYPO3 Version set to 8
Actions
Copy link
 #17

Updated by Gerrit Code Review over 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56957

Actions
Copy link
 #18

Updated by Gerrit Code Review over 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56957

Actions
Copy link
 #19

Updated by Gerrit Code Review over 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56957

Actions
Copy link
 #20

Updated by Gerrit Code Review over 6 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56957

Actions
Copy link
 #21

Updated by Gerrit Code Review over 6 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56957

Actions
Copy link
 #22

Updated by Benni Mack over 6 years ago

  • Target version changed from 8.7.13 to 8.7.19
Actions
Copy link
 #23

Updated by Susanne Moog about 6 years ago

  • Target version changed from 8.7.19 to Candidate for patchlevel
Actions
Copy link
 #24

Updated by Gerrit Code Review almost 6 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56957

Actions
Copy link
 #25

Updated by Benni Mack over 5 years ago

  • Related to Epic #88027: Properly handle Hooks/Signals and Events added
Actions
Copy link
 #26

Updated by Gerrit Code Review over 5 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/56957

Actions
Copy link
 #27

Updated by Gerrit Code Review over 5 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/56957

Actions
Copy link
 #28

Updated by Gerrit Code Review over 5 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61258

Actions
Copy link
 #29

Updated by Ricky Mathew over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #30

Updated by Gerrit Code Review over 5 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61258

Actions
Copy link
 #31

Updated by Gerrit Code Review over 5 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61280

Actions
Copy link
 #32

Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61280

Actions
Copy link
 #33

Updated by Ricky Mathew over 5 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #34

Updated by Benni Mack almost 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF