Bug #84985

Published workspace record show in page tree

Added by Oliver Hader over 1 year ago. Updated 7 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Workspaces
Target version:
-
Start date:
2018-05-12
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Steps to reproduce

  • switch to some workspace
  • change title of page & save
  • publish workspace version to live
  • reload page tree

Result

  • page tree shows modified value
  • page tree shows previous old version

Background

When publishing workspace records, the previous old version is still persisted with pid=-1 and t3ver_wsid=0 - that's correct. However, these records are not not filtered in the page tree.

Pointer

Flaws in resolving records in PageTreeRepository::fetchAllPages and maybe in BackendWorkspaceRestriction usage...


Related issues

Related to TYPO3 Core - Bug #85742: New page in workspace doesn't load content elements in preview Closed 2018-08-03

Associated revisions

Revision cda6c030 (diff)
Added by Benni Mack about 1 year ago

[BUGFIX] Select proper records in DBAL workspace restrictions

A new WorkspaceRestriction is added to solve all issues
once and for all.

For now, this restriction is used to only show
records in pagetree without having duplicated.

Resolves: #84985
Releases: master, 8.7
Change-Id: I22d5f276460107802bef3d390e6781434f1c28d3
Reviewed-on: https://review.typo3.org/56941
Tested-by: TYPO3com <>
Reviewed-by: Daniel Goerz <>
Reviewed-by: Achim Fritz <>
Tested-by: Achim Fritz <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision d7dc7168 (diff)
Added by Benni Mack about 1 year ago

[BUGFIX] Select proper records in DBAL workspace restrictions

A new WorkspaceRestriction is added to solve all issues
once and for all.

For now, this restriction is only added in v8.7 but not in use yet.

Resolves: #84985
Releases: master, 8.7
Change-Id: I22d5f276460107802bef3d390e6781434f1c28d3
Reviewed-on: https://review.typo3.org/58902
Tested-by: TYPO3com <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Oliver Hader over 1 year ago

  • Description updated (diff)

#2 Updated by Oliver Hader over 1 year ago

  • Description updated (diff)

#3 Updated by Oliver Hader over 1 year ago

  • Description updated (diff)

#4 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56941

#5 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56941

#6 Updated by Tymoteusz Motylewski over 1 year ago

  • Category changed from Pagetree to Workspaces

#7 Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56941

#8 Updated by Achim Fritz about 1 year ago

same Problem when discard a change in FE Preview

Steps to reproduce:

  • switch to some workspace
  • change title (e.g. "title" to "title2") of page & save
  • go to FE Preview and "discard" Change
  • reload page tree in Backend

Result:
both pages are shown in Tree

DB:

+---------+------+------+--------+-------------+-----------+----------+------------------------+-------------+------------+
| deleted | pid  | uid  | title  | t3ver_count | t3ver_oid | t3ver_id | t3ver_label            | t3ver_state | t3ver_wsid |
+---------+------+------+--------+-------------+-----------+----------+------------------------+-------------+------------+
|       0 | 4710 | 5488 | title  |           0 |         0 |        1 | First draft version    |           0 |          0 |
|       0 |   -1 | 5490 | title2 |           0 |      5488 |        2 | Auto-created for WS #4 |           0 |          0 |
+---------+------+------+--------+-------------+-----------+----------+------------------------+-------------+------------+

#9 Updated by Benni Mack about 1 year ago

Expected result (which should be adapted in PageTreeRepository - line 215) - When in workspace, records which have been published should never show up. These can be identified with "pid = -1 AND t3ver_wsid=0"

#10 Updated by Gerrit Code Review about 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56941

#11 Updated by Oliver Hader about 1 year ago

  • Related to Bug #85742: New page in workspace doesn't load content elements in preview added

#12 Updated by Gerrit Code Review about 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56941

#13 Updated by Gerrit Code Review about 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56941

#14 Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58902

#15 Updated by Benni Mack about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#16 Updated by Benni Mack 7 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF