Project

General

Profile

Actions

Task #85119

closed

Remove tests from subtree split Composer packages

Added by Mathias Brodala almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Category:
composer
Target version:
Start date:
2018-05-30
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

All typo3/cms-* subtree split Composer packages contain the Tests directory. These should be excluded from the Composer packages.

Actions #1

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57091

Actions #2

Updated by Tymoteusz Motylewski almost 6 years ago

does it influence the git subtree split or just the composer packages?
What is the influence on the users? Please give more context here.

Actions #3

Updated by Mathias Brodala almost 6 years ago

Tymoteusz Motylewski wrote:

does it influence the git subtree split or just the composer packages?
What is the influence on the users? Please give more context here.

Since the Composer packages only exist thanks to the Git subtree split it affects both.

The user will have TYPO3 packages without the Tests directory.

If you install typo3/cms (still possible with v8) you don't have any Tests directories in typo3/sysext/* thanks to the toplevel .gitattributes definition. However, if you install typo3/cms-* instead you will have them. This change addresses that by adding a separate .gitattributes file per package.

Actions #4

Updated by Mathias Brodala almost 6 years ago

To check the result of what Composer would produce you can use the following command to e.g. create a package for the core system extension after switching to its directory in the TYPO3 source:

git archive --format zip --output ../core.zip HEAD .

Without any change, you'll get an archive including the Tests directory. With the suggested change that directory will be gone as desired.

Actions #5

Updated by Mathias Brodala almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57151

Actions #7

Updated by Jigal van Hemert almost 6 years ago

  • Status changed from Under Review to Resolved
Actions #8

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF