Project

General

Profile

Actions

Bug #85260

closed

Can not create new page via context menu on root page as editor

Added by Christoph Lehmann almost 6 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Pagetree
Target version:
-
Start date:
2018-06-14
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

As an editor i have all permissions on a page which is marked as root page. I can not create a new page via context menu (right klick), but it works via drag&drop.


Files


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #81405: New pages are places at same level instead of under, when using the ContextMenu.Closed2017-06-01

Actions
Actions #1

Updated by Guido Schmechel over 5 years ago

Can reproduce it with 9.4.dev

master\typo3\sysext\backend\Classes\Form\FormDataProvider\DatabaseUserPermissionCheck.php function addData()
if (is_array($result['parentPageRow']))

$result['parentPageRow'] is null if editor creates a page at root. Admin user has a separate check and returns simple true

master\typo3\sysext\backend\Classes\Form\FormDataProvider\DatabaseParentPageRow.php
This class should return correctly null if root level is accessed.

Maybe its okay to use $result['neighborRow'] if $result['parentPageRow'] is null.

After that the saving throws this exception:
1: Attempt to insert a record on page '[root-level]' (0) from table 'pages' without permissions. Or non-existing page.

master\typo3\sysext\core\Classes\DataHandling\DataHandler.php
checkRecordInsertAccess() get a negative value via resolveSortingAndPidForNewRecord()

So a simple abs() does the trick

Actions #2

Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57497

Actions #3

Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57497

Actions #4

Updated by Riccardo De Contardi over 5 years ago

Is this the same issue? #81405

Actions #5

Updated by Riccardo De Contardi over 5 years ago

  • Related to Bug #81405: New pages are places at same level instead of under, when using the ContextMenu. added
Actions #6

Updated by Susanne Moog about 5 years ago

  • Category changed from Backend User Interface to Pagetree
  • Status changed from Under Review to New

Patch has been abandoned.

Actions #7

Updated by Sybille Peters almost 5 years ago

So you want to create a page as subpage of current page?

But if you use "New", the page is created (or tried to create) on same level as current page (under current page). I think this is currently not a bug, but it is not great either.

If you want to create a page as a subpage use the context menu: "More options" > "Create new wizard".

I think this is actually a duplicate of #81405 and should be closed.

Actions #8

Updated by Riccardo De Contardi almost 5 years ago

  • Status changed from New to Closed

I close this issue as a duplicate of #81405 , please continue the discussion there, thank you.
I have added there a reference to this issue to keep track of it; I've also added there the comment https://forge.typo3.org/issues/85260#note-1 to keep track of it, too.

If you think that this is the wrong decision, then please reopen it or open a new ticket and add a relation to this ticket number.

Thank you and best regards.

Actions

Also available in: Atom PDF