Task #85937

Epic #84726: Initiative: URL Routing Integration / Site Handling

Epic #84728: Introduce speaking URLs for pages

Epic #84729: Implement "slug" handling for pages and other records

Generate default slug for entities not being submitted via FormEngine

Added by Oliver Hader about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
DataHandler aka TCEmain
Target version:
Start date:
2018-08-23
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Entities that are not created using the FormEngine don't have "slug" fields as user submitted content and thus only will be filled with the default value (which is an empty string is this case). However, the slug should be generated based on the given input parameters (e.g. title field or position in rootline). This occurs e.g. for the following actions:

  • drag'n'drop creation of new pages in page tree
  • move page in page tree into new/different boundary of a site
  • copy page in general (handling of duplicate slug names)
  • create multiple pages via context menu (aka function wizards)

Fixing all these places might be one possibility, however it seems to be much better to introduce a specific handling in DataHandler (maybe similar to DataMapProcessor for l10n_state)


Related issues

Related to TYPO3 Core - Bug #86118: SlugEnricher.php misses strict_types Closed 2018-09-03
Duplicated by TYPO3 Core - Bug #86050: Creating pages with drag'n' drop in page tree doesnt create slug Closed 2018-08-31

Associated revisions

Revision 06c67dc4 (diff)
Added by Oliver Hader about 1 year ago

[BUGFIX] Ensure that slugs are always calculated in DataHandler

When NOT using FormEngine to create a new page (e.g. in the pagetree
or via the "Create multiple pages" wizard), so just using DataHandler
magic is uttermost critical that a slug is always created, to ensure
the "uniqueInSite" functionality, and to access a page, even though
the page was created after the upgrade wizard has run.

Resolves: #86050
Resolves: #85937
Releases: master
Change-Id: I9eff3385c369a04a6f5a33d0b840b6a2b698891c
Reviewed-on: https://review.typo3.org/58098
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision 793c84ef (diff)
Added by Andreas Fernandez about 1 year ago

[BUGFIX] Declare strict types in SlugEnricher

Resolves: #86118
Related: #85937
Releases: master
Change-Id: Id913e98e360d06f8db61bbde8c49a131715f2240
Reviewed-on: https://review.typo3.org/58151
Reviewed-by: Richard Haeser <>
Reviewed-by: Daniel Goerz <>
Tested-by: TYPO3com <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>

History

#1 Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58098

#2 Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58098

#3 Updated by Gerrit Code Review about 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58098

#4 Updated by Christian Kuhn about 1 year ago

  • Duplicated by Bug #86050: Creating pages with drag'n' drop in page tree doesnt create slug added

#5 Updated by Gerrit Code Review about 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58098

#6 Updated by Gerrit Code Review about 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58098

#7 Updated by Gerrit Code Review about 1 year ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58098

#8 Updated by Gerrit Code Review about 1 year ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58098

#9 Updated by Gerrit Code Review about 1 year ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58098

#10 Updated by Susanne Moog about 1 year ago

  • Target version changed from 9 LTS to 9.4

#11 Updated by Gerrit Code Review about 1 year ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58098

#12 Updated by Gerrit Code Review about 1 year ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58098

#13 Updated by Gerrit Code Review about 1 year ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58098

#14 Updated by Gerrit Code Review about 1 year ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58098

#15 Updated by Oliver Hader about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#16 Updated by Andreas Fernandez about 1 year ago

  • Related to Bug #86118: SlugEnricher.php misses strict_types added

#17 Updated by Gerrit Code Review about 1 year ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58160

#18 Updated by Oliver Hader about 1 year ago

  • Status changed from Under Review to Resolved

#19 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF