Bug #86067: TypoLink generation does not respect language settings - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #86067

closed

TypoLink generation does not respect language settings

Added by Benjamin Kott over 5 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Category:

Target version:

9.4

Start date:

2018-08-31

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Variant 1: Language Menu Processor

1. Create Site
2. Add Languages
3. Add Page
4. Translate Page
5. View Debug Information in Template for `languagenavigation`

10 = FLUIDTEMPLATE
10 {
    templateName = TEXT
    templateName {
        cObject = TEXT
        cObject {
            data = pagelayout
            required = 1
            case = uppercamelcase
            split {
                token = pagets__
                cObjNum = 1
                1.current = 1
            }
        }
        ifEmpty = Default
    }
    templateRootPaths {
        0 = EXT:extension/Resources/Private/Templates/Page/
    }
    partialRootPaths {
        0 = EXT:extension/Resources/Private/Partials/Page/
    }
    layoutRootPaths {
        0 = EXT:extension/Resources/Private/Layouts/Page/
    }
    dataProcessing {
        10 = TYPO3\CMS\Frontend\DataProcessing\LanguageMenuProcessor
        10 {
            languages = auto
            as = languagenavigation
        }
    }
}

Variant 2: TypoScript Language Menu

1. Create Site
2. Add Languages
3. Add Page
4. Translate Page
5. Render TypoScript Language Menu

page.15 = HMENU
page.15 {
    special = language
    special.value = auto
    wrap = <ul>|</ul>
    1 = TMENU
    1 {
        NO = 1
          NO.linkWrap  = <li>|</li>
    }
}

Variant 3: TypoLink

1. Create Site
2. Add Languages
3. Add Page
4. Translate Page
5. Render Link to current page in different language

page.20 = TEXT
page.20 {
  typolink.parameter.data = page:uid
  typolink.additionalParams = &L=1
}

Related issues 3 (0 open — 3 closed)

Actions

Copy link

Updated by Benjamin Kott over 5 years ago

Expected Results:
Generated Links are pointing to the page in a different language.

Actions

Copy link

Updated by Benjamin Kott over 5 years ago

Issue introduced in:
https://github.com/TYPO3/TYPO3.CMS/commit/7f0174beefa9e0a7305a09616d51d8f618b96930

Actions

Copy link

Updated by Frans Saris over 5 years ago

As far that I understood; with the new site configuration using typoscript like:

 typolink.additionalParams = &L=1

Isn't supported anymore. You now should use:

 typolink.language = 1

If you don't have a site configuration (pseudo site/fallback) then the old way should still work after some changes that were merged today.

Actions

Copy link

Updated by Frans Saris over 5 years ago

Related to Task #86058: Streamline page language linking added

Actions

Copy link

Updated by Frans Saris over 5 years ago

See #86058 for instance

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58108

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58108

Actions

Copy link

testing set 8, the language meno from variant 2 in a translated page does not work.

reproduce:
- create 'is_siteroot' page called "test"
- create a site config with / as base and 2 additional languages (danish/da and german/de in my case)
- create a root template on "test" page with the TS from above variant 2
- create a page below "test" root page called "congrats", unhide, have /congrats as slug
- create the two page translations, unhide them, have 2 slugs for them
- call FE with http://domain/congrats - works and properly links to the languages with an url like "http://domain/da/tranlate-to-da-congrats" and "http://domain/da/tranlate-to-de-congrats"
- call FE with http://domain/da/tranlate-to-da-congrats - the links to the 'default' and 'other' language are wrong, they just link to "http://domain/da/tranlate-to-da-congrats", too.

Actions

Copy link

#15

Updated by Gerrit Code Review over 5 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58108

Actions

Copy link

#16

Updated by Gerrit Code Review over 5 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58108

Actions

Copy link

#17

Updated by Gerrit Code Review over 5 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58108

Actions

Copy link

#18

Updated by Gerrit Code Review over 5 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58108

Actions

Copy link

#19