Project

General

Profile

Actions
Copy link

Bug #86535

closed

Install Tool: Manage Language Packs: Language packs can't be updated if all packages exists

Added by Josef Glatz about 6 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Install Tool
Target version:
Candidate for patchlevel
Start date:
2018-10-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Problem/Description

I was confused when ext:news was not shown within the language pack module. Until Georg has enlightened me: https://github.com/georgringer/news/issues/746#issuecomment-426077132

  • UI is not understandable
  • I can't force a language pack update for ext:news if all packages where downloaded for the package.

Possible solution (discussed with Georg Ringer) (initially added/discussed an 2020-03-30)

Since it is possible to update language packs for all existing extensions/sysextensions with one button, it should also be possible to do that per extension per language.

  • A download icon must be shown instead of the icon-actions-system-refresh icons for the buttons
  • Every extension must be shown in the Translation status table (second table) no matter if language packages are already installed
    • The buttons must be also shown with a download icons

With that you can update or try to download a language pack for each single extension for each single language. It's the same like the existing "Update all" button in the first table "Active languages" just for one extension – which saves also unnecessary bandwidth and time.

Files

Download all files
86535-patchset1.png (92 KB) 86535-patchset1.png Josef Glatz, 2020-03-30 11:31
language_update.png (61.6 KB) language_update.png Jonas Eberle, 2020-03-30 11:50
Actions
Copy link
 #1

Updated by Josef Glatz about 6 years ago

  • Category changed from Language Manager (backend) to Install Tool
Actions
Copy link
 #2

Updated by Georg Ringer over 4 years ago

  • Status changed from New to Needs Feedback

can't reprodcue that anymore, can you recheck?

Actions
Copy link
 #4

Updated by Josef Glatz over 4 years ago

  • Description updated (diff)
  • Status changed from Needs Feedback to Accepted
Actions
Copy link
 #5

Updated by Gerrit Code Review over 4 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64003

Actions
Copy link
 #6

Updated by Josef Glatz over 4 years ago

Gerrit Code Review wrote:

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64003

Patch-Set 1 from Georg is what I expect.

Also the Updates are working from my perspective.

Screenshot of Patch-Set 1 and 3:

Actions
Copy link
 #7

Updated by Jonas Eberle over 4 years ago

Is it intended that it does not show the current state (if downloaded or not) any more?

Before patch:

Actions
Copy link
 #8

Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64003

Actions
Copy link
 #9

Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64003

Actions
Copy link
 #10

Updated by Josef Glatz over 4 years ago

Patch Set 3: Looks good to me

Don't get the problem which Jonas reports.

What is actually possible with the patch set:

  • I can push the button to update all language packages for all extensions with one click
  • I can push the button to update a single language pack of an extension no matter if the language pack exists locally since the TYPO3 instance doesn't know if there are updates on the translation-/crowdin-serverside.
  • The download button looks more intuitive, since there are no checks if there is an update

What is not really part of this issue, is the fact, that if you update a language pack where no language pack is available the message is green – this is another issue IMO.

Actions
Copy link
 #11

Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64003

Actions
Copy link
 #12

Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63982

Actions
Copy link
 #13

Updated by Georg Ringer over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #14

Updated by Gerrit Code Review over 4 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63982

Actions
Copy link
 #15

Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63982

Actions
Copy link
 #16

Updated by Georg Ringer over 4 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #17

Updated by Benni Mack over 4 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF