Bug #86574

PageRepository misses check for $versioningWorkspaceId > 0

Added by Frank Naegler 9 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Workspaces
Target version:
Start date:
2018-10-04
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

With #85078 some checks in frontend/Classes/Page/PageRepository has been changed from versioningPreview (bool) to versioningWorkspaceId (int).
The old bool value was set with a check versioningWorkspaceId > 0 which is now missing and break if backend user has set workspace to -99 which is the default.


Related issues

Related to TYPO3 Core - Task #85078: Deprecate PageRepository->versioningPreview Closed 2018-05-25
Related to TYPO3 Core - Bug #86605: Error when trying to display categories through a backend module Closed 2018-10-09

Associated revisions

Revision 528328dc (diff)
Added by Markus Klein 8 months ago

[BUGFIX] Fix version preview checks in PageRepository

This patch corrects all conditions for version preview in the
PageRepository class, which have been converted incorrectly
with #85078.

Resolves: #86574
Releases: master
Change-Id: I9a77f2de7c6c8abab9e5b3a1012c1582ed863fdd
Reviewed-on: https://review.typo3.org/58577
Tested-by: TYPO3com <>
Tested-by: Frank Naegler <>
Reviewed-by: Benni Mack <>
Reviewed-by: Frank Naegler <>
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>

History

#1 Updated by Frank Naegler 9 months ago

  • Related to Task #85078: Deprecate PageRepository->versioningPreview added

#2 Updated by Gerrit Code Review 9 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58577

#3 Updated by Tymoteusz Motylewski 8 months ago

Hi Frank,
Can you share some testing scenarios?

#4 Updated by Frank Naegler 8 months ago

use an admin user in the backend and you run into to problem
for testing you can use the v9-cleanup branch of the blog extension: https://bitbucket.typo3.com/projects/EXT/repos/blog/browse?at=refs%2Fheads%2Ftask%2Fv9cleanup
open the BE module breaks without the patch provided by Markus.

#5 Updated by Markus Klein 8 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Georg Ringer 8 months ago

  • Related to Bug #86605: Error when trying to display categories through a backend module added

#7 Updated by Benni Mack about 1 month ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF