Actions
Bug #86597
closedIncorrect query of the fallback uids in the core
Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Site Handling, Site Sets & Routing
Target version:
-
Start date:
2018-10-08
Due date:
% Done:
100%
Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:
On Location Sprint
Description
Hello core team,
if only the default language is selected during fallback in the site configuration, the query in the file sysext/core/Classes/Site/Entity/SiteLanguage.php
in line 153-155 no longer works because the query
if (!empty($attributes['fallbacks']))
fails because the array Attributes contains
fallbacks => '0'
.
Instead, it should be checked for isset
here.
Incorrect:
if (!empty($attributes['fallbacks'])) {
$this->fallbackLanguageIds = is_array($attributes['fallbacks']) ? $attributes['fallbacks'] : explode(',', $attributes['fallbacks']);
}
Correct:
if (isset($attributes['fallbacks'])) {
$this->fallbackLanguageIds = is_array($attributes['fallbacks']) ? $attributes['fallbacks'] : explode(',', $attributes['fallbacks']);
}
Updated by Georg Ringer almost 6 years ago
- Category changed from Localization to Site Handling, Site Sets & Routing
Updated by Susanne Moog almost 6 years ago
- Sprint Focus set to On Location Sprint
Updated by Gerrit Code Review almost 6 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58698
Updated by Anonymous almost 6 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 8ef66824da196cbac68053bf71fe09f72e143f2f.
Actions