Project

General

Profile

Actions
Copy link

Bug #86597

closed

Incorrect query of the fallback uids in the core

Added by Kay Röseler over 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
-
Start date:
2018-10-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:
On Location Sprint

Description

Hello core team,

if only the default language is selected during fallback in the site configuration, the query in the file sysext/core/Classes/Site/Entity/SiteLanguage.php in line 153-155 no longer works because the query

if (!empty($attributes['fallbacks']))

fails because the array Attributes contains

fallbacks => '0'.

Instead, it should be checked for isset here.

Incorrect:

if (!empty($attributes['fallbacks'])) {
    $this->fallbackLanguageIds = is_array($attributes['fallbacks']) ? $attributes['fallbacks'] : explode(',', $attributes['fallbacks']);
}

Correct:

if (isset($attributes['fallbacks'])) {
    $this->fallbackLanguageIds = is_array($attributes['fallbacks']) ? $attributes['fallbacks'] : explode(',', $attributes['fallbacks']);
}
Actions
Copy link

Also available in: Atom PDF