Bug #86793
closed
Renamed columns are not correctly detected by database schema diff
100%
Description
When using the default collation utf8mb4, renamed columns are not detected any more.
When you set up a new TYPO3 9.5 instance with MySQL
And rename one filed in any extensions ext_tables.sql file
I would expect to see the old field name offered to be dropped and a new field offered to be created with a new field name
What actually happens is, that database schema update does not show any changes.
Same is true for renaming an index.
Updated by Helmut Hummel over 5 years ago
- Related to Feature #80398: Make default charset and collation for new tables configurable added
Updated by Christian Kuhn over 5 years ago
confirmed. seen that, too. we had a fix related to this back in v8 times and should pick up some details from there. if that is related to utf8mb4, it's the explanation we did not see that earlier.
Updated by Gerrit Code Review over 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58787
Updated by Helmut Hummel over 5 years ago
Christian Kuhn wrote:
confirmed. seen that, too. we had a fix related to this back in v8 times and should pick up some details from there. if that is related to utf8mb4, it's the explanation we did not see that earlier.
Would be helpful, if you could pick up the change request or ticket from back then. I didn't find anything.
otoh I'm now pretty convinced, that I found a proper fix for that.
Code was broken since 8, but was issue was leveraged with utf8mb4 transition changes.
So maybe the fix is worth backporting to 8 although the error is not that easy to trigger (if at all for column renames)
Updated by Gerrit Code Review over 5 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58787
Updated by Christian Kuhn over 5 years ago
- Related to Bug #78771: ConnectionMigrator does not handle renamed columns added
Updated by Christian Kuhn over 5 years ago
- Related to Bug #81756: DatabaseSchemaComparator does not handle renamed columns added
Updated by Gerrit Code Review over 5 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58787
Updated by Helmut Hummel over 5 years ago
Thanks, the related tickets and change requests helped
Updated by Gerrit Code Review over 5 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58787
Updated by Helmut Hummel over 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 1a66bc91986e5cc4697eabd40728120e44036db3.
Updated by Benni Mack almost 5 years ago
- Status changed from Resolved to Closed