Task #86896

Apply CGL consistently in .yaml files

Added by Sybille Peters about 1 year ago. Updated about 1 month ago.

Status:
New
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-11-09
Due date:
% Done:

0%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
no-brainer
Sprint Focus:

Description

The CGL page for Yaml files has been added: https://docs.typo3.org/typo3cms/CoreApiReference/CodingGuidelines/CglYaml.html

The indenting with 2 spaces appears to be applied consistently in the core, but using double quotes ("") or ('') for strings is not.

double quotes:

  • rte_ckeditor

single quotes:

  • sites: generated config.yaml
  • form
  • typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/SlugScenario.yaml
  • ... all others I checked.

History

#1 Updated by Sybille Peters about 1 year ago

  • Complexity set to no-brainer

#2 Updated by Sybille Peters about 1 year ago

  • Category deleted (System/Bootstrap/Configuration)

#3 Updated by Sybille Peters about 1 month ago

.yaml <> .yml

Also, there are a lot of .yaml files:

typo3/sysext/backend/Tests/Functional/Fixtures/CommonScenario.yaml
typo3/sysext/core/Tests/Unit/Configuration/Loader/Fixtures/Subfolder/BaseTestInclusion.yaml
typo3/sysext/core/Tests/Unit/Configuration/Loader/Fixtures/Berta.yaml
typo3/sysext/core/Tests/Unit/Configuration/Fixtures/SiteConfigs/config2.yaml
typo3/sysext/core/Tests/Unit/Configuration/Fixtures/SiteConfigs/include.yaml
typo3/sysext/core/Tests/Unit/Configuration/Fixtures/SiteConfigs/config1_expected.yaml
typo3/sysext/core/Tests/Unit/Configuration/Fixtures/SiteConfigs/config1.yaml
typo3/sysext/core/Tests/Unit/Configuration/Fixtures/SiteConfigs/config2_expected.yaml
typo3/sysext/core/Tests/Unit/DependencyInjection/Fixtures/Package3/Configuration/Services.yaml
typo3/sysext/core/Tests/Unit/DependencyInjection/Fixtures/Package1/Configuration/Services.yaml
typo3/sysext/core/Tests/Unit/DependencyInjection/Fixtures/Package4Cycle/Configuration/Services.yaml
typo3/sysext/core/Tests/Unit/DependencyInjection/Fixtures/Package2/Configuration/Services.yaml
typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/ExtensionBuilder/settings.yaml
typo3/sysext/form/Tests/Unit/Mvc/Persistence/Fixtures/BlankForm.form.yaml
typo3/sysext/form/Tests/Unit/Mvc/Configuration/Fixtures/OverruleNonArrayValuesOverArrayValues2.yaml
typo3/sysext/form/Tests/Unit/Mvc/Configuration/Fixtures/OverruleNonArrayValuesOverArrayValues1.yaml
typo3/sysext/form/Tests/Unit/Mvc/Configuration/Fixtures/Header.yaml
typo3/sysext/form/Tests/Unit/Mvc/Configuration/Fixtures/Invalid.yaml
typo3/sysext/form/Tests/Unit/Controller/Fixtures/BlankForm.yaml
typo3/sysext/form/Tests/Unit/Controller/Fixtures/SimpleContactForm.yaml
typo3/sysext/form/Tests/Functional/Hooks/Fixtures/test_resources/Configuration/Yaml/AllowedExtensionPaths.yaml
typo3/sysext/form/Tests/Functional/Hooks/Fixtures/test_resources/Configuration/Form/updated.form.yaml
typo3/sysext/form/Tests/Functional/Hooks/Fixtures/test_resources/Configuration/Form/legacy.yaml
typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/SlugScenario.yaml
typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/PlainScenario.yaml
typo3/sysext/frontend/Tests/Functional/SiteHandling/LocalizedPageRendering/Fixtures/ScenarioC.yaml
typo3/sysext/frontend/Tests/Functional/SiteHandling/LocalizedPageRendering/Fixtures/ScenarioF.yaml
typo3/sysext/frontend/Tests/Functional/SiteHandling/LocalizedPageRendering/Fixtures/ScenarioB.yaml
typo3/sysext/frontend/Tests/Functional/SiteHandling/LocalizedPageRendering/Fixtures/ScenarioA.yaml
typo3/sysext/frontend/Tests/Functional/SiteHandling/LocalizedPageRendering/Fixtures/ScenarioD.yaml
typo3/sysext/frontend/Tests/Functional/SiteHandling/LocalizedPageRendering/Fixtures/ScenarioE.yaml

and a few .yml files:

typo3/sysext/seo/Tests/Functional/Fixtures/HrefLangScenario.yml
typo3/sysext/core/Tests/Acceptance/Install.suite.yml
typo3/sysext/core/Tests/Acceptance/Backend.suite.yml
typo3/sysext/core/Tests/codeception.yml

The CGL currently states .yaml as preferred (though in the field .yml seeems to be used dominantly, see also https://stackoverflow.com/questions/21059124/is-it-yaml-or-yml)

Also available in: Atom PDF