Bug #86954

Categories are lost, when saving before category tree is loaded completely

Added by Helmut Hummel 11 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-11-20
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

To reproduce:

  1. Have a category tree with a reasonable amount of categories (lets say 500 in 5 levels)
  2. Edit a record with categories field
  3. Select some categories and save
  4. Save immediately again once the save button becomes available again

Expectation:

Categories are still selected

Actual result:

No categories are selected


Related issues

Related to TYPO3 Core - Bug #89152: renderType='selectTree' generates warning with single value select New 2019-09-11

Associated revisions

Revision 18411d12 (diff)
Added by Nicole Cordes 5 months ago

[BUGFIX] Ensure correct initialization of selectTree value

This patch provides the current set database value in a hidden field as
early as the whole select tree JavaScript is provided. This prevents
data loss if the current record is saved before the select tree was loaded.

Resolves: #86954
Releases: master, 9.5, 8.7
Change-Id: I467b2a52d34b806713cd201a8a2a4f9bb8e92c71
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60415
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Tested-by: Frank Naegler <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Tymoteusz Motylewski <>
Reviewed-by: Frank Naegler <>

Revision 1fcc4a09 (diff)
Added by Nicole Cordes 5 months ago

[BUGFIX] Ensure correct initialization of selectTree value

This patch provides the current set database value in a hidden field as
early as the whole select tree JavaScript is provided. This prevents
data loss if the current record is saved before the select tree was loaded.

Resolves: #86954
Releases: master, 9.5, 8.7
Change-Id: I467b2a52d34b806713cd201a8a2a4f9bb8e92c71
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60767
Tested-by: TYPO3com <>
Tested-by: Frank Naegler <>
Reviewed-by: Frank Naegler <>

Revision e9422c8a (diff)
Added by Nicole Cordes 5 months ago

[BUGFIX] Ensure correct initialization of selectTree value

This patch provides the current set database value in a hidden field as
early as the whole select tree JavaScript is provided. This prevents
data loss if the current record is saved before the select tree was loaded.

Resolves: #86954
Releases: master, 9.5, 8.7
Change-Id: I467b2a52d34b806713cd201a8a2a4f9bb8e92c71
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60768
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Tested-by: Frank Naegler <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Frank Naegler <>

History

#1 Updated by Mathias Brodala 11 months ago

I can confirm the issue on TYPO3v8.

#2 Updated by Gerrit Code Review 7 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60415

#3 Updated by Gerrit Code Review 6 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60415

#4 Updated by Gerrit Code Review 5 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60767

#5 Updated by Gerrit Code Review 5 months ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60768

#6 Updated by Nicole Cordes 5 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Thomas Luzat about 1 month ago

  • Related to Bug #89152: renderType='selectTree' generates warning with single value select added

Also available in: Atom PDF