Project

General

Profile

Actions

Task #87009

closed

Additional translationFile removes default file

Added by Jan Delius almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Category:
Form Framework
Target version:
-
Start date:
2018-11-26
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:
Remote Sprint

Description

When an extension adds a translationFile (e.g. with a numeric key), the default file from EXT:form is removed.

For this reason, the integrator must add the default file each time it wants to overwrite or add a single label.
The default yaml settings should use numeric keys to prevent this scenario.

Actions #1

Updated by Jan Delius almost 6 years ago

  • Category set to Form Framework
Actions #2

Updated by Ralf Zimmermann almost 6 years ago

https://docs.typo3.org/typo3cms/extensions/form/Concepts/FrontendRendering/Index.html#translate-form-definition

"
Due to compatibility issues, the setting translationFile is not defined as an array in the default configuration. To load your own translation files, you should define an array containing 'EXT:form/Resources/Private/Language/locallang.xlf' as first entry (key 10) followed by your own file (key 20) as displayed in the example above.
"

Actions #3

Updated by Jan Delius almost 6 years ago

Which behaviour will break if the default configuration changes here?
  • If anyone override translationFile with a single string they don't want to have a default value there and overrides the whole behaviour
  • If anyone override/changed translationFile with numeric keys they will have the default file as 10 or doesn't use them, so they don't care about core changes here.

If I have to carry the entry for the default file every time I want to override these setting that would be much unnecessary code. Additional the default file(e.g. the location/path) can never be changed in core without be a breaking for any extension that overrides just a single label. We should check to change the default config syntax to a array now and do that in 10 if anything will break up.

Actions #4

Updated by Ralf Zimmermann almost 6 years ago

The current translation file configuration within the current ext:form core setup is a string.
If we change the translation file to an array, we have to define the ext:form core tranlation file within some array key, lets say "10".
In the meentime, an integrator has defined some additional translation files and therefore the integrator has switched to the array notation within its ext:form setup override.
Lets say the integrator has choosen the array key 0 for the ext:form core translation file and 1 for its own.
If we ship a new ext:form core configuration with TYPO3 8 / 9 with the array notation, we change the behavior of the integrators TYPO3 instance.
In this scenario the array key 0 contains the ext:form core file, key 1 the integrators custom file and within key 10 we have the ext:form core file again.
I will try to deprecate the string syntax within TYPO3 v10, this could make the change in version 11 available.

Actions #5

Updated by Björn Jacob over 5 years ago

  • Tracker changed from Bug to Task
  • Priority changed from Should have to Must have
  • Sprint Focus set to Remote Sprint

This has to be done early in the development process of v10. Improving this is a change in behaviour.

Actions #6

Updated by Mathias Brodala over 5 years ago

  • Status changed from New to In Progress
  • Assignee set to Mathias Brodala
  • TYPO3 Version changed from 8 to 10
Actions #7

Updated by Gerrit Code Review over 5 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60593

Actions #8

Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60593

Actions #9

Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60593

Actions #10

Updated by Gerrit Code Review over 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60593

Actions #11

Updated by Gerrit Code Review over 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60593

Actions #12

Updated by Gerrit Code Review over 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60593

Actions #13

Updated by Gerrit Code Review over 5 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60593

Actions #14

Updated by Gerrit Code Review over 5 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60593

Actions #15

Updated by Gerrit Code Review over 5 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60593

Actions #16

Updated by Gerrit Code Review over 5 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60593

Actions #17

Updated by Mathias Brodala over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #18

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF