Bug #87090

Site module > Umlauts in domains not working with the new url handling / routing

Added by Mario Kober 5 months ago. Updated 13 days ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
-
Start date:
2018-12-06
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Hi all,

if you enter a domain containing umlauts in the site-config as entry point everything seems fine in the backend but the routing is not working. Every url is pointing to the root page.

I think we should output an error message when entering umlauts or it should be converted automatically.

from IDN:
geƤndert.de

to ACE-String:
xn--gendert-6wa.de

Best, Mario


Related issues

Related to TYPO3 Core - Bug #87843: Unicode characters as entry point in site configurations Closed 2019-03-05
Related to TYPO3 Core - Bug #87893: Update composer.json file for core extension Closed 2019-03-13
Related to TYPO3 Core - Bug #87953: SiteMatcher Warning: Use of undefined constant INTL_IDNA_VARIANT_UTS46 Closed 2019-03-19

Associated revisions

Revision 11292caf (diff)
Added by Benni Mack 2 months ago

[BUGFIX] Allow umlaut domains for site domain resolving

As umlaut domains require to be puny-coded, this needs
to be added into the request context of the SiteMatcher.

A polyfill package "symfony/polyfill-intl-idn" is installed
to ensure that the methods exist at all times. If "ext-intl"
is not available, the polyfill package is used.

Installed via
composer require symfony/polyfill-intl-idn

Resolves: #87090
Resolves: #87843
Releases: master, 9.5
Change-Id: I209c01953b3a0f2c25b4e1f11ab74ed4bb29f569
Reviewed-on: https://review.typo3.org/c/59958
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Tested-by: Oliver Hader <>
Tested-by: Benni Mack <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Oliver Hader <>
Reviewed-by: Benni Mack <>

Revision acbe862c (diff)
Added by Benni Mack 2 months ago

[BUGFIX] Update core system extension composer.json file

In commit #11292caf2016587f61ab32258e848d24ae5db663
the update of composer.json was forgotten, so this is added
now.

Resolves: #87893
Related: #87090
Related: #87843
Releases: master
Change-Id: Iff0ce9c5272794f5f433a1098faba7db3e7f1ae0
Reviewed-on: https://review.typo3.org/c/60233
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Benni Mack <>

Revision 620f113a (diff)
Added by Benni Mack 2 months ago

[BUGFIX] Allow umlaut domains for site domain resolving

As umlaut domains require to be puny-coded, this needs
to be added into the request context of the SiteMatcher.

A polyfill package "symfony/polyfill-intl-idn" is installed
to ensure that the methods exist at all times. If "ext-intl"
is not available, the polyfill package is used.

Installed via
composer require symfony/polyfill-intl-idn

Resolves: #87090
Resolves: #87843
Releases: master, 9.5
Change-Id: I209c01953b3a0f2c25b4e1f11ab74ed4bb29f569
Reviewed-on: https://review.typo3.org/c/60232
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Josef Glatz 5 months ago

Maybe we can leave the string as-is and add something like https://packagist.org/packages/true/punycode "to the getter of an url"?

#2 Updated by Riccardo De Contardi 4 months ago

  • Category set to Link Handling, Site Handling & Routing

#3 Updated by Gerrit Code Review 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59958

#4 Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59958

#5 Updated by Benni Mack 2 months ago

  • Related to Bug #87843: Unicode characters as entry point in site configurations added

#6 Updated by Gerrit Code Review 2 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59958

#7 Updated by Gerrit Code Review 2 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59958

#8 Updated by Gerrit Code Review 2 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59958

#9 Updated by Gerrit Code Review 2 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60232

#10 Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60232

#11 Updated by Benni Mack 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#12 Updated by Benni Mack 2 months ago

  • Related to Bug #87893: Update composer.json file for core extension added

#13 Updated by Benni Mack 13 days ago

  • Status changed from Resolved to Closed

#14 Updated by Oliver Hader 13 days ago

  • Related to Bug #87953: SiteMatcher Warning: Use of undefined constant INTL_IDNA_VARIANT_UTS46 added

Also available in: Atom PDF