Bug #87380

AspectFactory::enrich uses 'class_uses' to check for trait, does not work for inherited classes

Added by Wolfgang Klinger almost 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
-
Start date:
2019-01-09
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

\TYPO3\CMS\Core\Routing\Aspect\AspectFactory::enrich uses 'class_uses' to check for trait,
but this does not work for inherited classes.

So if someone extends e.g. the PersistedJoinMapper this leads to an exception because $this->siteLanguage is not set.

A better solution would be to check if the property 'siteLanguage' exists in the object.

#1

Updated by Wolfgang Klinger almost 3 years ago

  • Description updated (diff)
#2

Updated by Christian Eßl about 2 years ago

  • Category set to Link Handling, Site Handling & Routing
#3

Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61893

#4

Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61893

#5

Updated by Christian Eßl almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#6

Updated by Benni Mack almost 2 years ago

  • Status changed from Resolved to Closed
#7

Updated by Gerrit Code Review over 1 year ago

  • Status changed from Closed to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63329

#8

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63329

#9

Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63329

#10

Updated by Christian Eßl over 1 year ago

  • Status changed from Under Review to Resolved
#11

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF