Bug #87380
closed
AspectFactory::enrich uses 'class_uses' to check for trait, does not work for inherited classes
100%
Description
\TYPO3\CMS\Core\Routing\Aspect\AspectFactory::enrich uses 'class_uses' to check for trait,
but this does not work for inherited classes.
So if someone extends e.g. the PersistedJoinMapper this leads to an exception because $this->siteLanguage is not set.
A better solution would be to check if the property 'siteLanguage' exists in the object.
Updated by
Updated by Christian Eßl over 4 years ago
- Category set to Link Handling, Site Handling & Routing
Updated by Gerrit Code Review over 4 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61893
Updated by Gerrit Code Review over 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61893
Updated by Christian Eßl over 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 2485bdf54e6b95085af5ab1e487a8bceb3b4251c.
Updated by
Updated by Gerrit Code Review about 4 years ago
- Status changed from Closed to Under Review
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63329
Updated by Gerrit Code Review about 4 years ago
Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63329
Updated by Gerrit Code Review about 4 years ago
Patch set 3 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63329
Updated by Christian Eßl about 4 years ago
- Status changed from Under Review to Resolved
Applied in changeset 237381467ea0fe4a7c9c27d1c28209f0655f8669.
Updated by Oliver Klee about 2 years ago
- Related to Task #97435: Properly deprecate the check for the SiteLanguageAwareTrait added