Project

General

Profile

Actions

Bug #87380

closed

AspectFactory::enrich uses 'class_uses' to check for trait, does not work for inherited classes

Added by Wolfgang Klinger about 5 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
-
Start date:
2019-01-09
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

\TYPO3\CMS\Core\Routing\Aspect\AspectFactory::enrich uses 'class_uses' to check for trait,
but this does not work for inherited classes.

So if someone extends e.g. the PersistedJoinMapper this leads to an exception because $this->siteLanguage is not set.

A better solution would be to check if the property 'siteLanguage' exists in the object.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #97435: Properly deprecate the check for the SiteLanguageAwareTraitClosed2022-04-20

Actions
Actions #1

Updated by Wolfgang Klinger about 5 years ago

  • Description updated (diff)
Actions #2

Updated by Christian Eßl over 4 years ago

  • Category set to Link Handling, Site Handling & Routing
Actions #3

Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61893

Actions #4

Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61893

Actions #5

Updated by Christian Eßl over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack about 4 years ago

  • Status changed from Resolved to Closed
Actions #7

Updated by Gerrit Code Review about 4 years ago

  • Status changed from Closed to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63329

Actions #8

Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63329

Actions #9

Updated by Gerrit Code Review about 4 years ago

Patch set 3 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63329

Actions #10

Updated by Christian Eßl about 4 years ago

  • Status changed from Under Review to Resolved
Actions #11

Updated by Benni Mack about 4 years ago

  • Status changed from Resolved to Closed
Actions #12

Updated by Oliver Klee almost 2 years ago

  • Related to Task #97435: Properly deprecate the check for the SiteLanguageAwareTrait added
Actions

Also available in: Atom PDF