Project

General

Profile

Actions

Feature #87457

closed

Use symfony/property-info to gather doc block information

Added by Alexander Schnitzler almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Category:
Extbase
Start date:
2019-01-16
Due date:
% Done:

100%

Estimated time:
PHP Version:
7.3
Tags:
Complexity:
Sprint Focus:

Description

This patch introduces the requirement to symfony/property-info
which provides a neat api to extract information about
properties via several different extractors.

The package comes with a PhpDocExtractor, which is kind of
a drop in replacement (functional wise) for the extbase
DocCommentParser which has been removed.

Along with the replacement of the doc block extractor
the package comes with an api to fetch context data that
enables us to resolve non fully qualified class names.

This is now possible:

```
use TYPO3\CMS\Extbase\Persistence\ObjectStorage;
use ExtbaseTeam\BlogExample\Domain\Model\Comment;

class Post {
/* * @var ObjectStorage<Comment>
*/
public $comments;
}
```

Important:
This only works in extbase models as the reflection
costs are high and the information is only needed
in this case.

The non fully qualified class name is now also
supported for injection properties, although it is
still recommended to avoid injection properties in
favor of injection methods or constructor injection.

Example:

```
use TYPO3\CMS\Extbase\Annotation as Extbase;
use TYPO3\CMS\Extbase\Configuration\ConfigurationManager;

class Service {
/* * @Extbase\Inject * @var ConfigurationManager
*/
public $configurationManager;
}
```


Related issues 3 (0 open3 closed)

Related to TYPO3 Core - Bug #88033: Massive performance degration since symfony/property-infoClosed2019-03-29

Actions
Related to TYPO3 Core - Feature #93197: Use symfony/property-info for method params tooClosed2020-12-31

Actions
Precedes TYPO3 Core - Bug #87838: ClassSchema must analyze all property doc blocksClosedAlexander Schnitzler2019-01-172019-01-17

Actions
Actions #1

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59454

Actions #2

Updated by Gerrit Code Review almost 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59454

Actions #3

Updated by Gerrit Code Review almost 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59454

Actions #4

Updated by Gerrit Code Review almost 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59454

Actions #5

Updated by Gerrit Code Review almost 6 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59454

Actions #6

Updated by Gerrit Code Review almost 6 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59454

Actions #7

Updated by Gerrit Code Review almost 6 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59454

Actions #8

Updated by Gerrit Code Review almost 6 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59454

Actions #9

Updated by Gerrit Code Review almost 6 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59454

Actions #10

Updated by Gerrit Code Review almost 6 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59454

Actions #11

Updated by Gerrit Code Review almost 6 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59454

Actions #12

Updated by Gerrit Code Review almost 6 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59454

Actions #13

Updated by Gerrit Code Review almost 6 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59454

Actions #14

Updated by Gerrit Code Review almost 6 years ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59454

Actions #15

Updated by Gerrit Code Review almost 6 years ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59454

Actions #16

Updated by Gerrit Code Review almost 6 years ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59454

Actions #17

Updated by Gerrit Code Review almost 6 years ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59454

Actions #18

Updated by Anonymous almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #19

Updated by Alexander Schnitzler over 5 years ago

  • Precedes Bug #87838: ClassSchema must analyze all property doc blocks added
Actions #20

Updated by Christian Kuhn over 5 years ago

  • Related to Bug #88033: Massive performance degration since symfony/property-info added
Actions #21

Updated by Christian Kuhn over 5 years ago

This leads to a massive performance degration up to factor 7 rendering the backend and especially the install tool close to unusable with empty caches. see https://forge.typo3.org/issues/88033

Actions #22

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions #23

Updated by Nikita Hovratov almost 4 years ago

  • Related to Feature #93197: Use symfony/property-info for method params too added
Actions

Also available in: Atom PDF