Bug #87610: Filelist Search - Add constraint to avoid searching of records marked as missing. - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #87610

closed

Filelist Search - Add constraint to avoid searching of records marked as missing.

Added by Ricky Mathew almost 6 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Category:

File Abstraction Layer (FAL)

Target version:

next-patchlevel

Start date:

2019-02-01

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

7.2

Tags:

Complexity:

easy

Is Regression:

Sprint Focus:

Description

The filelist search now fetches all records except deleted and hidden on a matching string.It should avoid searching for records marked as missing, since those fetched missing records leads to Folder not found or File not found Exceptions like in the following screenshot.

As a work around i just added the 'missing = 0' constraint at the end of findBySearchWordInMetaData() in TYPO3\CMS\Core\Resource\Index\FileIndexRepository class

$queryBuilder->andWhere(
                $queryBuilder->expr()->eq($sysFileTableName.'.missing', $queryBuilder->createNamedParameter(0, \PDO::PARAM_INT))
        );
        $result = $queryBuilder->execute();
        $fileRecords = [];

If this workaround feels sensible can someone please push it to the gerrit review?

Files

file_not_found.png (173 KB) file_not_found.png

Ricky Mathew, 2019-02-01 07:42

Related issues 3 (0 open — 3 closed)

Actions

Copy link

Updated by Guido Schmechel over 5 years ago

Assignee set to Helmut Hummel

https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985 Helmut works on a complete new approach. Maybe he can say something about the current state?

Basically, I'm with you and find that the problem should be solved even for 8.7.

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Status changed from New to Under Review

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

Updated by Helmut Hummel over 5 years ago

Status changed from Under Review to New
Assignee deleted (~~Helmut Hummel~~)

I created a patch already

https://review.typo3.org/#/c/Packages/TYPO3.CMS/+/58985/

This tackles a whole lot more than just missing files, and already works on a production system in one of my projects like that.

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Status changed from New to Under Review

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#10

Updated by Gerrit Code Review over 5 years ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#11

Updated by Gerrit Code Review over 5 years ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#12

Updated by Gerrit Code Review over 5 years ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#13

Updated by Gerrit Code Review over 5 years ago

Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#14

Updated by Gerrit Code Review over 5 years ago

Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#15

Updated by Benni Mack over 5 years ago

Target version changed from next-patchlevel to Candidate for patchlevel

Actions

Copy link

#16

Updated by Gerrit Code Review over 5 years ago

Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#17

Updated by Gerrit Code Review over 5 years ago

Patch set 24 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#18

Updated by Gerrit Code Review over 5 years ago

Patch set 25 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#19

Updated by Gerrit Code Review over 5 years ago

Patch set 26 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#20

Updated by Gerrit Code Review over 5 years ago

Patch set 27 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#21

Updated by Benni Mack over 5 years ago

Target version changed from Candidate for patchlevel to next-patchlevel

Actions

Copy link

#22

Updated by Gerrit Code Review over 5 years ago

Patch set 28 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#23

Updated by Gerrit Code Review over 5 years ago

Patch set 29 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#24

Updated by Gerrit Code Review over 5 years ago

Patch set 29 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#25

Updated by Gerrit Code Review over 5 years ago

Patch set 29 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#26

Updated by Gerrit Code Review over 5 years ago

Patch set 30 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#27

Updated by Gerrit Code Review over 5 years ago

Patch set 31 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#28

Updated by Gerrit Code Review over 5 years ago

Patch set 32 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#29

Updated by Gerrit Code Review over 5 years ago

Patch set 33 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#30

Updated by Gerrit Code Review over 5 years ago

Patch set 34 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#31

Updated by Gerrit Code Review over 5 years ago

Patch set 35 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#32

Updated by Gerrit Code Review over 5 years ago

Patch set 35 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#33

Updated by Gerrit Code Review over 5 years ago

Patch set 36 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#34

Updated by Gerrit Code Review over 5 years ago

Patch set 37 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/58985

Actions

Copy link

#35

Updated by Gerrit Code Review over 5 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60685

Actions

Copy link

#36