Bug #87820
closed
Logger not instanciated in cache backend
100%
Description
The function setLogger is never called in cache backend.
The cache backend is instanciated via 'new' and not via GeneralUtility::makeInstance in TYPO3\CMS\Core\Cache\CacheManager::createCache.
This leads to an error, when the logger in cache backend class is needed: 'Core: Exception handler (WEB): Uncaught TYPO3 Exception: Call to a member function alert() on null ...'
Updated by Benni Mack over 5 years ago
Hmm, this is a tricky one.
Basically, because AbstractBackend is a LoggerAwareInterface, basically all caches that are used until ext_localconf.phps are loaded (cache_core, assets) will not have their final Logger Configuration set. We can add this manually, which would make sense, but this might result in more side-effects...
But the solution for this patch would be: createCache() checks for the LoggerAwareInterface and puts in the code, like makeInstance does it.
Updated by
Updated by Daniel Windloff over 5 years ago
- Has duplicate Bug #88775: logger in ApcuBackend is not instantiated added
Updated by Stephan Ederer over 5 years ago
This bug is a showstopper.
We've got redundant server nodes. If one node is down the website is still online.
But if the Redis-Server is down (for maintenance e.g.), the webside is down too.
Updated by Gerrit Code Review over 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61472
Updated by Gerrit Code Review over 5 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61472
Updated by Gerrit Code Review over 5 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61472
Updated by Gerrit Code Review over 5 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61472
Updated by Gerrit Code Review over 5 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61460
Updated by Anja Leichsenring over 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 524b6701fa0e690f5239fefb0024b58f7767cfcd.
Updated by Anja Leichsenring over 5 years ago
- Related to Bug #88938: wrong class statement for logger initialization added
Updated by Benni Mack almost 5 years ago
- Status changed from Resolved to Closed