Bug #87942

List view - deault language flag and label set only with TSConfig

Added by Riccardo De Contardi 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
-
Start date:
2019-03-17
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Steps to reproduce

1) TYPO3 9.5.x or 10.0.0-dev (latest master)
2) Set a Default language in the site configuration (e.g. Italian) ; set also anoter language (e.g. English)
3) Create a page and translate it
4) Create a content element and translate it
5) Go to list view

Results:

on the column [localization] there is no flag for the default language, which is called "Default"

To have the correct label and flag you still have to set the TSConfig options:

mod.SHARED.defaultLanguageFlag   
mod.SHARED.defaultLanguageLabel

Expected Result

the configuration on the Site Configuration should be taken, instead and the TSConfig options should not be used.

p.s. I don't know if they're already deprecated


Related issues

Related to TYPO3 Core - Bug #87965: Language arrangments in BE not adhering to site config.yaml structure Needs Feedback 2019-03-20

Associated revisions

Revision b91e3606 (diff)
Added by Georg Ringer 4 months ago

[BUGFIX] Use SiteMatcher in TranslationConfigurationProvider

The TranslationConfigurationProvider must use the SiteMatcher
to find the proper languages and must not depend only on fetching
from sys_language.

Resolves: #87942
Releases: master, 9.5
Change-Id: Ib8b8a980d7997effa38a6c2dcfbe8a3e7e3eb1a6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60336
Tested-by: TYPO3com <>
Tested-by: Riccardo De Contardi <>
Tested-by: Anja Leichsenring <>
Tested-by: Benni Mack <>
Reviewed-by: Anja Leichsenring <>
Reviewed-by: Benni Mack <>

Revision 6920cd53 (diff)
Added by Georg Ringer 4 months ago

[BUGFIX] Use SiteMatcher in TranslationConfigurationProvider

The TranslationConfigurationProvider must use the SiteMatcher
to find the proper languages and must not depend only on fetching
from sys_language.

Resolves: #87942
Releases: master, 9.5
Change-Id: Ib8b8a980d7997effa38a6c2dcfbe8a3e7e3eb1a6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60351
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Riccardo De Contardi 4 months ago

  • Description updated (diff)

#2 Updated by Riccardo De Contardi 4 months ago

  • Subject changed from List view - language flag and label set only with TSConfig to List view - deault language flag and label set only with TSConfig

#3 Updated by Georg Ringer 4 months ago

  • Category changed from Backend User Interface to Link Handling, Site Handling & Routing
  • Status changed from New to Accepted

problem is in \TYPO3\CMS\Backend\Configuration\TranslationConfigurationProvider::getSystemLanguages which doesn't check the sites at all

#4 Updated by Georg Ringer 4 months ago

  • Related to Bug #87965: Language arrangments in BE not adhering to site config.yaml structure added

#5 Updated by Gerrit Code Review 4 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60336

#6 Updated by Gerrit Code Review 4 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60351

#7 Updated by Georg Ringer 4 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8 Updated by Benni Mack 3 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF