Project

General

Profile

Actions

Bug #88055

closed

Faulty error-handling when uploading large files

Added by Jarvis H about 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Form Framework
Start date:
2019-04-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:
Remote Sprint

Description

Typo3 Version: 9.5.4

Error 1: File size exceeds post_max_size

How to reproduce:
- Upload file larger then post_max_size

Error shown:
Warning: POST Content-Length of 215854163 bytes exceeds the limit of 104857600 bytes in Unknown on line 0

Suspected cause:
This is the normal error handling for php, but maybe it is possible to check if the file is too large before this occurs, to ensure a proper error message.

Error 2: Memory error when file size exceeds available memory

--> Moved to #88235


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #88235: Ext: form file upload Memory error when file size exceeds available memoryClosedSusanne Moog2019-04-27

Actions
Actions #1

Updated by Jarvis H about 5 years ago

  • Priority changed from Should have to Must have
Actions #2

Updated by Björn Jacob about 5 years ago

  • Sprint Focus set to Remote Sprint
Actions #3

Updated by Susanne Moog almost 5 years ago

  • Related to Bug #88235: Ext: form file upload Memory error when file size exceeds available memory added
Actions #4

Updated by Susanne Moog almost 5 years ago

  • Description updated (diff)
  • Status changed from New to In Progress
  • Assignee set to Susanne Moog
  • Target version set to Candidate for Major Version
Actions #5

Updated by Gerrit Code Review almost 5 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60595

Actions #6

Updated by Gerrit Code Review almost 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60595

Actions #7

Updated by Susanne Moog almost 5 years ago

We cannot sensible catch the error as it is coming directly from PHP (and in this case not via the PHP upload error handling but we never even get to the point where $_FILES is filled).

As the install tool already checks mismatches of post_max_size and upload_max_size this would clearly be a misconfiguration of either TYPO3 or the server and should not be handled in form. However, to allow the editor / form integrator to react to max size issues the current patch now displays a hint with the configured max size that is usable at that moment so an integrator can either use that or talk to their admin to get the configuration fixed.

Additionally, I moved error 2 to a separate issue.

Actions #8

Updated by Gerrit Code Review almost 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60595

Actions #9

Updated by Gerrit Code Review almost 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60595

Actions #10

Updated by Gerrit Code Review almost 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60595

Actions #11

Updated by Anonymous almost 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #12

Updated by Benni Mack almost 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF