Bug #88238
closedext:form predefined mime types are always set
100%
Description
The ext:form setup contains some predefined mime types for the elements "FileUpload" and "ImageUpload"
- https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/form/Configuration/Yaml/BaseSetup.yaml#L254
- https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/form/Configuration/Yaml/BaseSetup.yaml#L260
Such predefined values are used as starting values while the form element is factorized:
- https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/form/Classes/Domain/Factory/ArrayFormFactory.php#L104
- https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/form/Classes/Domain/Model/FormElements/AbstractSection.php#L138
later on, the values from the form definition will be overlayed (https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/form/Classes/Domain/Model/FormElements/AbstractFormElement.php#L148):
A form definition like this
type: Form identifier: test-1 label: test prototypeName: standard renderables: - type: Page identifier: page-1 label: Step renderables: - type: FileUpload identifier: fileupload-1 label: 'File upload' properties: saveToFileMount: '1:/user_upload/' allowedMimeTypes: - application/pdf
ends up in a form element like this
type: FileUpload identifier: fileupload-1 label: 'File upload' properties: saveToFileMount: '1:/user_upload/' allowedMimeTypes: - application/msword - application/vnd.openxmlformats-officedocument.wordprocessingml.document - application/vnd.oasis.opendocument.text - application/pdf
We need to remove the predefined mime types from the ext:form setup-
Updated by Gerrit Code Review over 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60617
Updated by Gerrit Code Review about 5 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60617
Updated by Gerrit Code Review about 5 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60617
Updated by Gerrit Code Review about 5 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60617
Updated by Gerrit Code Review about 5 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60617
Updated by Anonymous almost 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 60f5155e8b2922bf59e7b14be6977f487266c16d.
Updated by Benni Mack almost 5 years ago
- Status changed from Resolved to Closed
Updated by Björn Jacob almost 5 years ago
- Related to Bug #90188: Re-implement strict mimetype validation added
Updated by Mathias Brodala about 4 years ago
- Related to Bug #92309: Missing feature flag processing/check added
Updated by Björn Jacob over 3 years ago
- Related to Task #94871: Remove feature flag and related code added