TYPO3 Core

Hello

How your links are generated ? ckeditor, viewhelper ?
What is the generated markup ?

DANIEL Rémy wrote:

Hello

How your links are generated ? ckeditor, viewhelper ?
What is the generated markup ?

Hi Daniel, the ckeditor was used where the editor markup is as following

<p>DE Text mit <a href="t3://page?uid=1">internem Link</a> und <a href="http://delme.buechler.pro/">externem Link</a></p>

In the frontend it is

<p>DE Text mit <a href="/">internem Link</a> und <a href="http://delme.buechler.pro/" target="_blank">externem Link</a></p>

I reproduce it on TYPO3 9.5.5.

for internal links this is easy to solve

--- a/typo3/sysext/fluid_styled_content/Configuration/TypoScript/Helper/ParseFunc.typoscript
+++ b/typo3/sysext/fluid_styled_content/Configuration/TypoScript/Helper/ParseFunc.typoscript
@@ -18,7 +18,7 @@ lib.parseFunc {
                 parameter.data = parameters:href
                 title.data = parameters:title
                 ATagParams.data = parameters:allParams
-                target.data = parameters:target
+                target.override.data = parameters:target
                 extTarget = {$styles.content.links.extTarget}
                 extTarget.override.data = parameters:target
             }

for external links I don't have yet a solution for core.

however for fixing I would do

lib.parseFunc.tags.a.typolink.extTarget = _self
ib.parseFunc.tags.a.typolink.target = _blank

I tried the below TS (with 9.5.7) but couldn't observe any change.

lib.parseFunc {
  parameter.data = parameters:href
  title.data = parameters:title
  ATagParams.data = parameters:allParams
  target.data = parameters:target
  target.override.data = parameters:target
  extTarget = {$styles.content.links.extTarget}
  extTarget.override.data = parameters:target
}
lib.parseFunc.tags.a.typolink.extTarget = _self
lib.parseFunc.tags.a.typolink.target = _blank

We have the same problem when creating links to pages using Data Processing and typolink is added to the target=_blank.

When calling the LegacyLinkBuilder class, the value of the target is extTarget instead of intTarget.

Unfortunately, there is no possibility to detect whether the given url is internal or external. The only way would be to parse the given URL. Also it's possible to assign another value as target when building the url. But the default is always to use extTarget.

$target = $target ?: $this->resolveTargetAttribute($conf, 'extTarget', true, $tsfe->extTarget);

Roman, you should try to set
config.extTarget = {$styles.content.links.extTarget}
and use the constant to define the value, which makes your life much easier!

In addition, I created a patch to change this.

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62184

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62281