Project

General

Profile

Actions

Task #88511

closed

Useless TCA configuration for pages table

Added by Markus Klein over 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Backend User Interface
Target version:
-
Start date:
2019-06-06
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
no-brainer
Sprint Focus:

Description

With #82445 the TCA configuration of the pages table was adjusted and two useless settings where introduced.

'l10n_mode' => 'prefixLangTitle' may only be set on input fields and not for checkboxes.

Actions #1

Updated by Gerrit Code Review over 5 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60891

Actions #2

Updated by Oliver Hader over 5 years ago

Did it have any side-effects in the database?
By looking into the code it should not have had any... (prefixLangTitle only for TCA types text and input)

if ($fCfg['l10n_mode'] === 'prefixLangTitle') {
    if (($fCfg['config']['type'] === 'text' || $fCfg['config']['type'] === 'input') && (string)$row[$fN] !== '') {

Actions #3

Updated by Markus Klein over 5 years ago

No effect in the DB, hence no bug-report.

I found that today, when I was looking at v8 and searching whether nav_hide is actually translatable. Which it is not.
Then I looked in v9 and found that it got no l10n_mode=exclude, hence it is translatable.
Benni suggested to add the sync feature to the fields, which I can agree with.

Actions #4

Updated by Gerrit Code Review over 5 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60891

Actions #5

Updated by Gerrit Code Review over 5 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60891

Actions #6

Updated by Gerrit Code Review over 5 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60891

Actions #7

Updated by Gerrit Code Review over 5 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60891

Actions #8

Updated by Gerrit Code Review over 5 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60891

Actions #9

Updated by Markus Klein over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Gerrit Code Review over 5 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61402

Actions #11

Updated by Markus Klein over 5 years ago

  • Status changed from Under Review to Resolved
Actions #12

Updated by Benni Mack almost 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF