Task #88511
closedUseless TCA configuration for pages table
100%
Description
With #82445 the TCA configuration of the pages table was adjusted and two useless settings where introduced.
'l10n_mode' => 'prefixLangTitle'
may only be set on input fields and not for checkboxes.
Updated by Gerrit Code Review over 5 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60891
Updated by Oliver Hader over 5 years ago
Did it have any side-effects in the database?
By looking into the code it should not have had any... (prefixLangTitle
only for TCA types text
and input
)
if ($fCfg['l10n_mode'] === 'prefixLangTitle') { if (($fCfg['config']['type'] === 'text' || $fCfg['config']['type'] === 'input') && (string)$row[$fN] !== '') {
Updated by Markus Klein over 5 years ago
No effect in the DB, hence no bug-report.
I found that today, when I was looking at v8 and searching whether nav_hide is actually translatable. Which it is not.
Then I looked in v9 and found that it got no l10n_mode=exclude, hence it is translatable.
Benni suggested to add the sync feature to the fields, which I can agree with.
Updated by Gerrit Code Review over 5 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60891
Updated by Gerrit Code Review over 5 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60891
Updated by Gerrit Code Review over 5 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60891
Updated by Gerrit Code Review over 5 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60891
Updated by Gerrit Code Review over 5 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60891
Updated by Markus Klein over 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b359e4f98da46c92c34ed0efed8f1078896dfa7e.
Updated by Gerrit Code Review over 5 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61402
Updated by Markus Klein over 5 years ago
- Status changed from Under Review to Resolved
Applied in changeset 2d6dcbb34cf3068d91386064a0a3dd531a487e74.
Updated by Benni Mack almost 5 years ago
- Status changed from Resolved to Closed