Project

General

Profile

Actions

Bug #88539

closed

Form Framework: same filename in different storages not possible

Added by Andreas Kiessling almost 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2019-06-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:
Remote Sprint

Description

Within a multisite setup, i have several ContactRequest.form.yaml files, one for each domain.
Each domain has an own folder for storing forms.

When i open the Forms backend module, only forms with a unique filename show up
The list is generated through \TYPO3\CMS\Form\Mvc\Persistence\FormPersistenceManager::retrieveYamlFilesFromStorageFolders, but since it iterates over all storage folders, but only uses the filenames to generate the list of forms to show in the module.

https://github.com/TYPO3/TYPO3.CMS/blob/TYPO3_8-7/typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php#L390

            $files = $folder->getFiles(
                0,
                0,
                Folder::FILTER_MODE_USE_OWN_AND_STORAGE_FILTERS,
                true
            );
            $filesFromStorageFolders = $filesFromStorageFolders + $files;

Thus the resulting list only consists of files with unique filenames, whereas the full path or hash should be used to distinguish the form definitions
The code seems to be there from the beginning, thus should be fixed in 8.7, 9.5 and master


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #89666: PersistenceManagerException with two extensions providing a form definition with the same nameRejected2019-11-13

Actions
Actions #1

Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61891

Actions #2

Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61891

Actions #3

Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61891

Actions #4

Updated by Susanne Moog over 4 years ago

  • Sprint Focus set to Remote Sprint
Actions #5

Updated by Mathias Brodala over 4 years ago

  • Related to Bug #89666: PersistenceManagerException with two extensions providing a form definition with the same name added
Actions #6

Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61891

Actions #7

Updated by Gerrit Code Review over 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61891

Actions #8

Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62397

Actions #9

Updated by Christian Eßl over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Benni Mack over 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF