Project

General

Profile

Actions

Feature #88844

closed

Change status of message "Localization failed: there already are localizations" from ERROR to INFO

Added by Stefan Padberg over 5 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Localization
Target version:
-
Start date:
2019-07-26
Due date:
% Done:

100%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Observed with TYPO3 CMS v9.5.4

When localizing children data with the "localize all data" button in the parent element (1:n relation), a red error message is displayed, when some of the data is already localised. But this is not an error, it is a regular situation when additional children data are added! It could be an error only when you use the button for the first time.

Please change the status of the message to INFO or at least to WARNING.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Feature #88845: acknowledge backend messages with one click?Closed2019-07-26

Actions
Actions #1

Updated by Frank Nägler over 5 years ago

  • Category set to Localization
  • Status changed from New to Accepted
  • Assignee set to Frank Nägler
Actions #2

Updated by Frank Nägler over 5 years ago

  • Related to Feature #88845: acknowledge backend messages with one click? added
Actions #3

Updated by Frank Nägler over 5 years ago

  • Assignee deleted (Frank Nägler)
Actions #4

Updated by Christian Berger over 4 years ago

Yes. We do have the same issue. It's completely confusing for our editors. I would highly appreciate this little change!

Actions #5

Updated by Torben Hansen over 4 years ago

I tried to work on a patch here, but it came out that this is not as easy as it sounds.

Background:

Localizations for inline items are generated through the TYPO3 DataHandler in DataHandler::inlineLocalizeSynchronize(). Here, all inline items are fetched and regardless of, if a localization for a record exist or not, (DataHandler::localize()) is used to create a localization. The shown error message is generated in DataHandler::localize(), which is widely used in DataHandler to create translations. So it might be correct to show the error for non-inline records, but for inline records, the error is useless.

Changing the error message to e.g. a warning is also not that easy, since again the scenario of inline vs. non-inline record has be be respected.

I think it would be best, if DataHandler::inlineLocalizeSynchronize() will check, if a translation for a record exist and if so, not tries to create a new translation for it. This would result in those error messages not being shown at all.

Actions #6

Updated by Gerrit Code Review over 4 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65059

Actions #7

Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65059

Actions #8

Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65059

Actions #9

Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65059

Actions #10

Updated by Gerrit Code Review over 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65059

Actions #11

Updated by Gerrit Code Review over 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65059

Actions #12

Updated by Gerrit Code Review over 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65059

Actions #13

Updated by Gerrit Code Review over 3 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65059

Actions #14

Updated by Gerrit Code Review over 3 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65059

Actions #15

Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68637

Actions #16

Updated by Torben Hansen over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #17

Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68637

Actions #18

Updated by Torben Hansen over 3 years ago

  • Status changed from Under Review to Resolved
Actions #19

Updated by Benni Mack over 3 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF