Task #88991
closed
Unify handling of errorParams in linkvalidator
0%
Description
- protected parameter errorParams is unnecessarily redefined in ExternalLinktype class (already introduced in parent class AbstractLinkType)
- initializing of errorParams done differently in each class, can be done in one way in AbstractLinkType
- usage of errorParams is done differently in various Linktype checker classes
- the error message is constructed twice, once when it is written into tx_linkvalidator_link.url_reponse and again when it is read from the database for the report
only the errorParams['errorMessage'] needs to be stored in the database, not the restThis is actually not a good idea because error message should be localized when report is generated
Updated by Gerrit Code Review over 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61521
Updated by Gerrit Code Review over 5 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61521
Updated by Sybille Peters about 5 years ago
- Related to Task #84717: Reconsider serialized array for Linkvalidator added
Updated by Gerrit Code Review about 5 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61521
Updated by Gerrit Code Review about 5 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61521
Updated by Gerrit Code Review about 5 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61521
Updated by Gerrit Code Review about 5 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61521
Updated by Sybille Peters over 4 years ago
- Status changed from Under Review to New
Updated by Sybille Peters almost 3 years ago
- Category set to Linkvalidator
- Status changed from New to Closed