Project

General

Profile

Actions

Task #88991

closed

Unify handling of errorParams in linkvalidator

Added by Sybille Peters over 5 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Should have
Category:
Linkvalidator
Target version:
-
Start date:
2019-08-21
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

  • protected parameter errorParams is unnecessarily redefined in ExternalLinktype class (already introduced in parent class AbstractLinkType)
  • initializing of errorParams done differently in each class, can be done in one way in AbstractLinkType
  • usage of errorParams is done differently in various Linktype checker classes
  • the error message is constructed twice, once when it is written into tx_linkvalidator_link.url_reponse and again when it is read from the database for the report
  • only the errorParams['errorMessage'] needs to be stored in the database, not the rest This is actually not a good idea because error message should be localized when report is generated

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #84717: Reconsider serialized array for LinkvalidatorClosedSybille Peters2019-12-13

Actions
Actions

Also available in: Atom PDF