Task #84717

Epic #85006: Epic: Improve broken link handling in TYPO3 / linkvalidator rewrite

Reconsider serialized array for Linkvalidator

Added by Sybille Peters over 1 year ago. Updated 1 day ago.

Status:
New
Priority:
Should have
Category:
Linkvalidator
Target version:
-
Start date:
2018-04-13
Due date:
% Done:

0%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

see decisions:Breaking LinkValidator

Specifically the field tx_linkvalidator_link.url_response is used to handle results of link check, including the error message:

It may contain something like this:

a:2:{s:5:"valid";b:0;s:11:"errorParams";a:2:{s:9:"errorType";s:7:"network";s:7:"message";s:30:"Network error / invalid domain";}}

Also, the errorParams array includes an errorType and the (localized) error message. This does not really make sense anyway, because it is localized while checking links. It should be localized while viewing results because checking links and viewing the results may be done by different users at different times (and checking may also be done via the scheduler).

I am not creating another issue for this, but this should be considered when handling the array differently. Probably it would be sufficient to store the errorType in a seperate database field.


Related issues

Related to TYPO3 Core - Task #83338: Move scheduler tasks from serialized data to JSON New 2017-12-15
Related to TYPO3 Core - Task #88991: Unify handling of errorParams in linkvalidator Under Review 2019-08-21

History

#1 Updated by Susanne Moog over 1 year ago

  • Related to Task #83338: Move scheduler tasks from serialized data to JSON added

#2 Updated by Sybille Peters over 1 year ago

  • Subject changed from Reconsider serialized array to Reconsider serialized array for Linkvalidator

#3 Updated by Sybille Peters over 1 year ago

  • Description updated (diff)

#4 Updated by Sybille Peters over 1 year ago

  • Parent task set to #85006

#5 Updated by Sybille Peters 1 day ago

  • Description updated (diff)

#6 Updated by Sybille Peters 1 day ago

  • Related to Task #88991: Unify handling of errorParams in linkvalidator added

Also available in: Atom PDF