Task #84717

Reconsider serialized array for Linkvalidator

Added by Sybille Peters over 1 year ago. Updated 13 days ago.

Status:
New
Priority:
Should have
Category:
Linkvalidator
Target version:
-
Start date:
2018-04-13
Due date:
% Done:

0%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

see decisions:Breaking LinkValidator

Can be converted to JSON as suggested in #83338 for scheduler.

Specifically the field tx_linkvalidator_link.url_response is used to handle results of link check, including the error message:

It may contain something like this:

a:2:{s:5:"valid";b:0;s:11:"errorParams";a:2:{s:9:"errorType";s:7:"network";s:7:"message";s:30:"Network error / invalid domain";}}

So, we have:

  • bool valid (currently only used if _GP('showalllinks') is set, not really used, maybe we can remove this entirely)
  • errorParams array, depends on type of link: * external: * string errorType * string message (should be removed also, we should get the error message when generating the report, depending on current language of BE user) * exception * page (internal) link: * in addition to errorType and message: contains additional information about page / content element * other: ...

Also, the errorParams array includes an errorType and the (localized) error message. This does not really make sense anyway, because it is localized while checking links. It should be localized while viewing results because checking links and viewing the results may be done by different users at different times (and checking may also be done via the scheduler).

I am not creating another issue for this, but this should be considered when handling the array differently.

It might also make sense to store the errorType in a seperate database field for easier aggregation of results.


Related issues

Related to TYPO3 Core - Task #83338: Move scheduler tasks from serialized data to JSON New 2017-12-15
Related to TYPO3 Core - Task #88991: Unify handling of errorParams in linkvalidator Under Review 2019-08-21

History

#1 Updated by Susanne Moog over 1 year ago

  • Related to Task #83338: Move scheduler tasks from serialized data to JSON added

#2 Updated by Sybille Peters over 1 year ago

  • Subject changed from Reconsider serialized array to Reconsider serialized array for Linkvalidator

#3 Updated by Sybille Peters over 1 year ago

  • Description updated (diff)

#4 Updated by Sybille Peters over 1 year ago

  • Parent task set to #85006

#5 Updated by Sybille Peters 2 months ago

  • Description updated (diff)

#6 Updated by Sybille Peters 2 months ago

  • Related to Task #88991: Unify handling of errorParams in linkvalidator added

#7 Updated by Sybille Peters 2 months ago

  • Description updated (diff)

#8 Updated by Sybille Peters 13 days ago

  • Parent task deleted (#85006)

Also available in: Atom PDF