Bug #89002
closedList view search can't search for integer search phrase
100%
Description
My table TCA searchFields are:
'searchFields' => '......,customer_number',
My field configuration is
'customer_number' => [
.......
'config' => [
'type' => 'input',
'size' => 30,
'eval' => 'int, unique',
'readOnly' => 1,
'max' => 11
],
],
In case I put number as a search phrase in TYPO3 main backend search I can find my record.
In case I put number as a search phrase in TYPO3 list view search I can not find my record.
Related core code: https://github.com/TYPO3/TYPO3.CMS/blob/TYPO3_8-7/typo3/sysext/recordlist/Classes/RecordList/AbstractDatabaseRecordList.php#L979
TYPO3 is excluding from searchFields those fields which has "int" in "eval" configuration field.
Workaround for that is to add pidonly configuration so my field looks like:
'customer_number' => [
...
'config' => [
'type' => 'input',
'size' => 30,
'eval' => 'int, unique',
'readOnly' => 1,
'max' => 11,
'search' => [
'pidonly' => 'pidonly'
]
],
],
This looks strange for me and I consider it as a TYPO3 bug. Also https://docs.typo3.org/m/typo3/reference-tca/master/en-us/ColumnsConfig/Type/Input.html#id77 says pidonly should be bool but it have effect only if it is 'pidonly' => 'pidonly' because in_array function usage in https://github.com/TYPO3/TYPO3.CMS/blob/TYPO3_8-7/typo3/sysext/recordlist/Classes/RecordList/AbstractDatabaseRecordList.php#L990.
Files
Updated by Michal Cygankiewicz about 5 years ago
It is not exactly the same. Here TYPO3 is excluding from searchFields those fields which has 'int' in 'eval' configuration and which don't have search|pidonly configuration which does not make sense too me. And it only happens to list view search and not toolbar search.
Updated by Gerrit Code Review about 5 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61884
Updated by Christian Eßl about 5 years ago
I can't find the sense in this check for 'pidonly' either... I investigated where this piece of code in AbstractDatabaseRecordList and found he following review:
https://review.typo3.org/c/Packages/TYPO3.CMS/+/2189/
I made a fix for this behaviour and described my reasoning in the commit message:
https://review.typo3.org/c/Packages/TYPO3.CMS/+/61884
Updated by Gerrit Code Review about 5 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61884
Updated by Gerrit Code Review about 5 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61884
Updated by Gerrit Code Review about 5 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61884
Updated by Gerrit Code Review about 5 years ago
Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62061
Updated by Christian Eßl about 5 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 0cf65f8860c51bd70708eedd1de49075727150ff.
Updated by Benni Mack almost 5 years ago
- Status changed from Resolved to Closed
Updated by Christian Kuhn almost 3 years ago
- Related to Bug #96454: Wrong checks for TCA search options in DatabaseRecordList added