Task #89194

Upgrade wizard for slugs optimizations

Added by Sybille Peters 4 months ago. Updated 1 day ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2019-09-18
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues

Related to TYPO3 Core - Bug #88971: PopulatePageSlugs wizard finds and uses outdated realurl data Closed 2019-08-16
Related to TYPO3 Core - Bug #89964: PopulatePageSlugs.php should use order in query of getSuggestedSlugs Resolved 2019-12-16

Associated revisions

Revision 0311f671 (diff)
Added by Sybille Peters 1 day ago

[BUGFIX] Use latest slug in PopulatePageSlug

PopulatePageSlug is an upgrade wizard which migrates existing slugs
from realurl tables to the table pages.slug.

In realurl, when the page title changed, the realurl slug changed
(if not fixed). Realurl handled this by adding temporary entries to
its tables which would be used to redirect the URL to its new location.
These entries had a fixed expiration date (expire > 0). The final
slug had no expiration date (expire = 0)

The previous behaviour in PopulatePageSlug preferred entries from
tx_realurl_pathdata with an expiration date (expire > 0) over
entries without (expire = 0). This would prefer (temporary) entries
that were only used for the redirects over the final slug.

This patch uses the 'uid' for sorting in descending order, which
will always use the latest entry for a specific page / language
combinations.

Resolves: #89194
Related: #89964
Releases: master, 9.5
Change-Id: Ica18bf5c6df9d101ccfce7712eae9c979e558a11
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61719
Tested-by: TYPO3com <>
Tested-by: Albrecht Koehnlein <>
Tested-by: Sascha Rademacher <>
Tested-by: Frank Nägler <>
Reviewed-by: Albrecht Koehnlein <>
Reviewed-by: Sascha Rademacher <>
Reviewed-by: Frank Nägler <>

Revision 8758e9e6 (diff)
Added by Sybille Peters 1 day ago

[BUGFIX] Use latest slug in PopulatePageSlug

PopulatePageSlug is an upgrade wizard which migrates existing slugs
from realurl tables to the table pages.slug.

In realurl, when the page title changed, the realurl slug changed
(if not fixed). Realurl handled this by adding temporary entries to
its tables which would be used to redirect the URL to its new location.
These entries had a fixed expiration date (expire > 0). The final
slug had no expiration date (expire = 0)

The previous behaviour in PopulatePageSlug preferred entries from
tx_realurl_pathdata with an expiration date (expire > 0) over
entries without (expire = 0). This would prefer (temporary) entries
that were only used for the redirects over the final slug.

This patch uses the 'uid' for sorting in descending order, which
will always use the latest entry for a specific page / language
combinations.

Resolves: #89194
Related: #89964
Releases: master, 9.5
Change-Id: Ica18bf5c6df9d101ccfce7712eae9c979e558a11
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62942
Tested-by: TYPO3com <>
Tested-by: Frank Nägler <>
Reviewed-by: Frank Nägler <>

History

#1 Updated by Gerrit Code Review 4 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61718

#2 Updated by Sybille Peters 4 months ago

  • Related to Bug #88971: PopulatePageSlugs wizard finds and uses outdated realurl data added

#3 Updated by Gerrit Code Review 4 months ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61719

#4 Updated by Gerrit Code Review 4 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61719

#5 Updated by Gerrit Code Review 4 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61719

#6 Updated by Benni Mack 9 days ago

  • Related to Bug #89964: PopulatePageSlugs.php should use order in query of getSuggestedSlugs added

#7 Updated by Gerrit Code Review 8 days ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61719

#8 Updated by Gerrit Code Review 6 days ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61719

#9 Updated by Gerrit Code Review 6 days ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61719

#10 Updated by Gerrit Code Review 6 days ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61719

#11 Updated by Gerrit Code Review 2 days ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61719

#12 Updated by Gerrit Code Review 1 day ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62942

#13 Updated by Sybille Peters 1 day ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF