Bug #92568: PopulatePageSlugs upgrade wizard migrates wrong RealURL path data entry - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #92568

closed

PopulatePageSlugs upgrade wizard migrates wrong RealURL path data entry

Added by Mathias Brodala about 4 years ago. Updated almost 4 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Mathias Brodala

Category:

Site Handling, Site Sets & Routing

Target version:

next-patchlevel

Start date:

2020-10-15

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

The PopulatePageSlugs upgrade wizard allows to migrate entries from tx_realurl_pathdata. However, due to an additional DESC sorting, the wrong entry is used in case there is more than one for a page. This can actually happen often for $reasons.

Given the following two entries in tx_realurl_pathdata:

uid	...	pagepath	expire
1	...	first/path	0
2	...	second/path	0

RealURL will use the first/path, but the PopulatePageSlugs upgrade wizard will use the second/path. This leads to changed URLs after the upgrade.

RealURL itself does not apply any explicit sorting:

https://github.com/dmitryd/typo3-realurl/blob/2.6.2/Classes/Cache/DatabaseCache.php#L286

        $row = $this->databaseConnection->exec_SELECTgetSingleRow('*', 'tx_realurl_pathdata',
            'pid=' . (int)$pageId .
                ' AND language_id=' . (int)$languageId .
                ' AND rootpage_id=' . (int)$rootPageId .
                ' AND mpvar=' . ($mpVar ? $this->databaseConnection->fullQuoteStr($mpVar, 'tx_realurl_pathdata') : '\'\'') .
                ' AND expire=0'
        );

Thus in this case ASC is used by default.

Related issues 4 (0 open — 4 closed)

Actions

Copy link

Updated by Gerrit Code Review about 4 years ago

Status changed from New to Under Review

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66143

Actions

Copy link

Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66143

Actions

Copy link

Updated by Gerrit Code Review about 4 years ago

Patch set 3 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66143

Actions

Copy link

Updated by Gerrit Code Review about 4 years ago

Patch set 4 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66143

Actions

Copy link

Updated by Gerrit Code Review about 4 years ago

Patch set 5 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66143

Actions

Copy link

Updated by Gerrit Code Review about 4 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66147

Actions

Copy link

Updated by Gerrit Code Review about 4 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66148

Actions

Copy link

Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66148

Actions

Copy link

Updated by Gerrit Code Review about 4 years ago

Patch set 3 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66148

Actions

Copy link

#10

Updated by Gerrit Code Review about 4 years ago

Patch set 6 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66143

Actions

Copy link

#11

Updated by Gerrit Code Review about 4 years ago

Patch set 7 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66143

Actions

Copy link

#12