Bug #88971

PopulatePageSlugs wizard finds and uses outdated realurl data

Added by Albrecht Köhnlein 3 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
-
Start date:
2019-08-16
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The PopulatePageSlugs (wich was introduced in TYPO3 9 with the new routing feature) finds and uses outdated realurl data


Related issues

Related to TYPO3 Core - Bug #89069: PopulatePagesSlugs should respect tx_realurl_pathsegment field New 2019-09-03
Related to TYPO3 Core - Task #89194: Upgrade wizard for slugs optimizations Under Review 2019-09-18

Associated revisions

Revision 64c8b4a0 (diff)
Added by Albrecht Köhnlein 2 months ago

[BUGFIX] Improve finding the correct realurl cache entry to create slug

Respect the `expire` field when selecting realurl cache data to generate
page slugs from realurl cache.
And also only the first found result will be used to simulate original
behavior of realurl, where `exec_SELECTgetSingleRow()` with internal
LIMIT 1 is used.

Resolves: #88971
Releases: master, 9.5
Change-Id: Ic008fc42c80d7c797c082fef1274d1ad925f09c1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61508
Tested-by: TYPO3com <>
Tested-by: Frank Nägler <>
Tested-by: Susanne Moog <>
Reviewed-by: Frank Nägler <>
Reviewed-by: Richard Haeser <>
Reviewed-by: Susanne Moog <>

Revision d661cc7b (diff)
Added by Albrecht Köhnlein 2 months ago

[BUGFIX] Improve finding the correct realurl cache entry to create slug

Respect the `expire` field when selecting realurl cache data to generate
page slugs from realurl cache.
And also only the first found result will be used to simulate original
behavior of realurl, where `exec_SELECTgetSingleRow()` with internal
LIMIT 1 is used.

Resolves: #88971
Releases: master, 9.5
Change-Id: Ic008fc42c80d7c797c082fef1274d1ad925f09c1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61611
Tested-by: TYPO3com <>
Tested-by: Richard Haeser <>
Reviewed-by: Richard Haeser <>

History

#1 Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61508

#2 Updated by Gerrit Code Review 3 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61508

#3 Updated by Joerg Kummer 3 months ago

I can confirm this behavior. You can check your installation and find such entries with such a SQL query (MySQL)

SELECT uid,pid,title,slug,deleted,hidden FROM pages WHERE slug REGEXP '^\/[0-9]'

#4 Updated by Gerrit Code Review 3 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61508

#5 Updated by Riccardo De Contardi 3 months ago

  • Category set to Link Handling, Site Handling & Routing

#6 Updated by Sybille Peters 3 months ago

  • Related to Bug #89069: PopulatePagesSlugs should respect tx_realurl_pathsegment field added

#7 Updated by Gerrit Code Review 2 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61611

#8 Updated by Albrecht Köhnlein 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#9 Updated by Sybille Peters 2 months ago

  • Related to Task #89194: Upgrade wizard for slugs optimizations added

Also available in: Atom PDF