Task #89206

Update @typo3/icons to 1.10.0

Added by Benjamin Kott about 1 year ago. Updated 10 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2019-09-19
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues

Related to TYPO3 Core - Bug #89250: "Rocket" icon in Install Tool does not respect font color Closed 2019-09-24
Related to TYPO3 Core - Task #91740: Remove deprecated icon identifier Resolved 2020-07-03
Precedes TYPO3 Core - Bug #89558: Bitmap icons for modules are not rendered anymore Closed 2019-09-20 2019-09-20

Associated revisions

Revision d750a7a2 (diff)
Added by Benjamin Kott about 1 year ago

[TASK] Update @typo3/icons to 1.10.0

Executed tasks:
cd Build
yarn add -D @
yarn build

Resolves: #89206
Releases: master
Change-Id: I47ae87e522acdce57e07804c46e3b8b8f29bc848
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61759
Tested-by: TYPO3com <>
Tested-by: Björn Jacob <>
Tested-by: Oliver Bartsch <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Björn Jacob <>
Reviewed-by: Oliver Bartsch <>
Reviewed-by: Andreas Fernandez <>

Revision b442a2a1 (diff)
Added by Andreas Fernandez about 1 year ago

[BUGFIX] Render "Admin Tools" icon in Install Tool as inline SVG

Resolves: #89250
Related: #89206
Releases: master
Change-Id: Ic865c7610f84674e9a3c06a2e01e67e9adb2fc25
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61798
Tested-by: Frank Nägler <>
Tested-by: Anja Leichsenring <>
Tested-by: TYPO3com <>
Reviewed-by: Frank Nägler <>
Reviewed-by: Anja Leichsenring <>
Reviewed-by: Björn Jacob <>

Revision 62650559 (diff)
Added by Benjamin Franzke 6 months ago

[BUGFIX] Fix inline icon rendering of bitmap icons

The existing "inline" rendering for icons causes bitmaps to be
rendered for SVG-inline usage using the <image> tag. This tag
can not be rendered in HTML context.

The backend module menu uses inlined SVGs. Rendering bitmap icons with
SVG-syntax, without an SVG root element, does not work in this context.
(Note: It works in SVG trees because the optional svg container is
removed by SvgTree.js and the image-tag is wrapped into a new <g> element)

We do now wrap "inline" bitmap icons into an svg tag, which will fix
the bitmap module case while the bitmap icons will still
be embeddable into svg groups (<g>) for svg trees.

Resolves: #89558
Related: #89206
Releases: master, 9.5
Change-Id: Ifaec3e697a45ba37b1ee23c0369414ce431cf4e8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64325
Tested-by: Markus Klein <>
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Markus Klein <>
Reviewed-by: Frank Nägler <>
Reviewed-by: Benni Mack <>

Revision 47cf00f6 (diff)
Added by Benjamin Franzke 6 months ago

[BUGFIX] Fix inline icon rendering of bitmap icons

The existing "inline" rendering for icons causes bitmaps to be
rendered for SVG-inline usage using the <image> tag. This tag
can not be rendered in HTML context.

The backend module menu uses inlined SVGs. Rendering bitmap icons with
SVG-syntax, without an SVG root element, does not work in this context.
(Note: It works in SVG trees because the optional svg container is
removed by SvgTree.js and the image-tag is wrapped into a new <g> element)

We do now wrap "inline" bitmap icons into an svg tag, which will fix
the bitmap module case while the bitmap icons will still
be embeddable into svg groups (<g>) for svg trees.

Resolves: #89558
Related: #89206
Releases: master, 9.5
Change-Id: Ifaec3e697a45ba37b1ee23c0369414ce431cf4e8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64290
Tested-by: Benjamin Franzke <>
Tested-by: TYPO3com <>
Reviewed-by: Benjamin Franzke <>

History

#1 Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61759

#2 Updated by Benjamin Kott about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#3 Updated by Andreas Fernandez about 1 year ago

  • Related to Bug #89250: "Rocket" icon in Install Tool does not respect font color added

#4 Updated by Xavier Perseguers 12 months ago

  • Precedes Bug #89558: Bitmap icons for modules are not rendered anymore added

#5 Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed

#6 Updated by Christian Kuhn 3 months ago

  • Related to Task #91740: Remove deprecated icon identifier added

Also available in: Atom PDF