Project

General

Profile

Actions

Bug #89558

closed

Bitmap icons for modules are not rendered anymore

Added by Xavier Perseguers over 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Start date:
2019-09-20
Due date:
2019-09-20
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
7.3
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

This is the updated module registration for EXT:ig_ldap_sso_auth in TYPO3 v10:

\TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerModule(
    $_EXTKEY,
    'system',
    'txigldapssoauthM1',
    'top',
    [
        \Causal\IgLdapSsoAuth\Controller\ModuleController::class => implode(',', [
            'index',
            'status',
            'search',
            'importFrontendUsers', 'importBackendUsers',
            'importFrontendUserGroups', 'importBackendUserGroups',
        ]),
    ], [
        'access' => 'admin',
        'icon' => 'EXT:' . $_EXTKEY . '/Resources/Public/Icons/module-ldap.png',
        'labels' => 'LLL:EXT:' . $_EXTKEY . '/Resources/Private/Language/locallang.xlf'
    ]
);

Prior to commit d750a7a2eae (#89206), or in TYPO3 v8/v9, the module was rendered like that:

In TYPO3 v10, this is what happens:

Reason is that this changed:

--- a/typo3/sysext/backend/Classes/Domain/Repository/Module/BackendModuleRepository.php
+++ b/typo3/sysext/backend/Classes/Domain/Repository/Module/BackendModuleRepository.php
@@ -348,7 +348,7 @@ class BackendModuleRepository implements \TYPO3\CMS\Core\SingletonInterface
         $iconRegistry = GeneralUtility::makeInstance(IconRegistry::class);
         if ($iconRegistry->isRegistered($iconIdentifier)) {
             $iconFactory = GeneralUtility::makeInstance(IconFactory::class);
-            return $iconFactory->getIcon($iconIdentifier)->render();
+            return $iconFactory->getIcon($iconIdentifier)->render('inline');
         }
         return '';
     }

which renders the Bitmap icon as:

<image width="32" height="32" xlink:href="/typo3conf/ext/ig_ldap_sso_auth/Resources/Public/Icons/module-ldap.png"/>

which in turns get interpreted like that by the browser:

<img width="32" height="32" xlink:href="/typo3conf/ext/ig_ldap_sso_auth/Resources/Public/Icons/module-ldap.png"/>

The tag lacks the src attribute and this originates from asking 'inline' alternative.


Files

v9.png (11.5 KB) v9.png Xavier Perseguers, 2019-10-31 11:46
v10.png (9.17 KB) v10.png Xavier Perseguers, 2019-10-31 11:48

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #90633: png Icons for BackendModulesClosed2020-03-04

Actions
Follows TYPO3 Core - Task #89206: Update @typo3/icons to 1.10.0Closed2019-09-19

Actions
Actions #1

Updated by Xavier Perseguers over 4 years ago

  • Due date set to 2019-09-20
  • Start date changed from 2019-10-31 to 2019-09-20
  • Follows Task #89206: Update @typo3/icons to 1.10.0 added
Actions #2

Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62168

Actions #3

Updated by Riccardo De Contardi about 4 years ago

Is this issue related? #90633

Actions #4

Updated by Xavier Perseguers about 4 years ago

@Riccardo De Contardi this is not only related, this is a duplicate of this one.

Actions #5

Updated by Susanne Moog about 4 years ago

  • Related to Bug #90633: png Icons for BackendModules added
Actions #6

Updated by Benni Mack almost 4 years ago

  • Target version changed from next-patchlevel to Candidate for patchlevel
Actions #7

Updated by Gerrit Code Review almost 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62168

Actions #8

Updated by Gerrit Code Review almost 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62168

Actions #9

Updated by Gerrit Code Review almost 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62168

Actions #10

Updated by Gerrit Code Review almost 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62168

Actions #11

Updated by Gerrit Code Review almost 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62168

Actions #12

Updated by Gerrit Code Review almost 4 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64325

Actions #13

Updated by Gerrit Code Review almost 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64325

Actions #14

Updated by Gerrit Code Review almost 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64325

Actions #15

Updated by Gerrit Code Review almost 4 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64290

Actions #16

Updated by Benjamin Franzke almost 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #17

Updated by Benni Mack almost 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF