Bug #89558

Bitmap icons for modules are not rendered anymore

Added by Xavier Perseguers 21 days ago. Updated 21 days ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2019-09-20
Due date:
2019-09-20
% Done:

0%

TYPO3 Version:
10
PHP Version:
7.3
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

This is the updated module registration for EXT:ig_ldap_sso_auth in TYPO3 v10:

\TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerModule(
    $_EXTKEY,
    'system',
    'txigldapssoauthM1',
    'top',
    [
        \Causal\IgLdapSsoAuth\Controller\ModuleController::class => implode(',', [
            'index',
            'status',
            'search',
            'importFrontendUsers', 'importBackendUsers',
            'importFrontendUserGroups', 'importBackendUserGroups',
        ]),
    ], [
        'access' => 'admin',
        'icon' => 'EXT:' . $_EXTKEY . '/Resources/Public/Icons/module-ldap.png',
        'labels' => 'LLL:EXT:' . $_EXTKEY . '/Resources/Private/Language/locallang.xlf'
    ]
);

Prior to commit d750a7a2eae (#89206), or in TYPO3 v8/v9, the module was rendered like that:

In TYPO3 v10, this is what happens:

Reason is that this changed:

--- a/typo3/sysext/backend/Classes/Domain/Repository/Module/BackendModuleRepository.php
+++ b/typo3/sysext/backend/Classes/Domain/Repository/Module/BackendModuleRepository.php
@@ -348,7 +348,7 @@ class BackendModuleRepository implements \TYPO3\CMS\Core\SingletonInterface
         $iconRegistry = GeneralUtility::makeInstance(IconRegistry::class);
         if ($iconRegistry->isRegistered($iconIdentifier)) {
             $iconFactory = GeneralUtility::makeInstance(IconFactory::class);
-            return $iconFactory->getIcon($iconIdentifier)->render();
+            return $iconFactory->getIcon($iconIdentifier)->render('inline');
         }
         return '';
     }

which renders the Bitmap icon as:

<image width="32" height="32" xlink:href="/typo3conf/ext/ig_ldap_sso_auth/Resources/Public/Icons/module-ldap.png"/>

which in turns get interpreted like that by the browser:

<img width="32" height="32" xlink:href="/typo3conf/ext/ig_ldap_sso_auth/Resources/Public/Icons/module-ldap.png"/>

The tag lacks the src attribute and this originates from asking 'inline' alternative.

v9.png View (11.5 KB) Xavier Perseguers, 2019-10-31 11:46

v10.png View (9.17 KB) Xavier Perseguers, 2019-10-31 11:48


Related issues

Follows TYPO3 Core - Task #89206: Update @typo3/icons to 1.10.0 Resolved 2019-09-19

History

#1 Updated by Xavier Perseguers 21 days ago

  • Due date set to 2019-09-20
  • Start date changed from 2019-10-31 to 2019-09-20
  • Follows Task #89206: Update @typo3/icons to 1.10.0 added

#2 Updated by Gerrit Code Review 21 days ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/62168

Also available in: Atom PDF