Bug #90986
closedEpic #92636: felogin bug collection
Felogin redirects on failed login when redirectMode is unset [patch]
100%
Description
Steps to reproduce:
- Create a Typo3 setup where no redirectMode is configured (e.g.
$conf['redirectMode'] === ''
). - Open the login form with a
redirect_url=/some-page
GET parameter. - Enter wrong credentials.
Current result:
- No error message is shown, and the user is redirected to /some-page even though not logged in.
Expected result:
- The user is not redirected, but stays on the login page where the error message is shown.
Analysis:
The bug is caused in FrontendLoginController::main()
. When redirectMode
is empty or not set, the $this->redirectUrl
is taken directly from the redirect_url
GET/POST parameter, and processRedirect()
is not called. Then, there is a final condition that checks whether to actually perform the redirect to $this->redirectUrl
or not:
if (($this->logintype === LoginType::LOGIN || $this->logintype === LoginType::LOGOUT) && ...) {
The problem is: This condition is true on a failed login.
This bug does not appear when redirectMode
is set, as in that case processRedirect()
will take care of failed logins.
The patch fixes this issue by adding the missing additional check for a successful login, i.e. $this->userIsLoggedIn
.
Files
Updated by Volker Diels-Grabsch over 4 years ago
- Subject changed from Felogin redirects on failed login when redirectMode is unset to Felogin redirects on failed login when redirectMode is unset [patch]
Updated by Gerrit Code Review over 4 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64111
Updated by Gerrit Code Review over 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64111
Updated by Gerrit Code Review over 4 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64111
Updated by Gerrit Code Review over 4 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64111
Updated by Joerg Kummer over 4 years ago
- TYPO3 Version changed from 9 to 10
The issue is also in version 10
Updated by Gerrit Code Review about 4 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64111
Updated by Gerrit Code Review almost 3 years ago
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70976
Updated by Volker Diels-Grabsch almost 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 5f4142b82e6ffb47df370be50d80e01a04d8fd78.
Updated by Benni Mack almost 2 years ago
- Status changed from Resolved to Closed