Task #91016

Epic #87417: Integrate proper Content Security Policy (CSP) handling

Task #87418: Refactor and remove usage of inline scripts in backend

Reduce inline JavaScript in ext:filelist

Added by Oliver Hader 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Security
Target version:
-
Start date:
2020-04-13
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues

Related to TYPO3 Core - Bug #91171: Renaming folder or file in filelist module throws PHP warning Closed 2020-04-22

Associated revisions

Revision 9199f254 (diff)
Added by Oliver Hader 3 months ago

[TASK] Reduce inline JavaScript in ext:filelist

This change aims to reduce the amount of inline JavaScript by
removing `onchange` or `onclick` events and dynamically created
JavaScript code/settings. There are still a couple of aspects
that need to be solved in a general way - e.g. assigning global
language labels (`TYPO3.lang`) or settings (`TYPO3.settings`).

  • allows `Modal` confirmation to emit `ModalResponseEvent`
  • extracts inline JavaScript from controllers & templates
  • introduces `BroadcastChannel` in `nav_frame` (folder tree)
  • uses plain links (`<a href="..."`) where applicable
  • updates folder tree when navigating in browser history

Resolves: #91016
Releases: master
Change-Id: Ied6a626e09df07bd1a240b9b6b4250cd6fff4c8a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64154
Tested-by: Andreas Fernandez <>
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64154

#2 Updated by Gerrit Code Review 3 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64154

#3 Updated by Oliver Hader 3 months ago

  • Subject changed from Remove inline JavaScript in ext:filelist to Reduce inline JavaScript in ext:filelist

#4 Updated by Gerrit Code Review 3 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64154

#5 Updated by Gerrit Code Review 3 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64154

#6 Updated by Gerrit Code Review 3 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64154

#7 Updated by Gerrit Code Review 3 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64154

#8 Updated by Gerrit Code Review 3 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64154

#9 Updated by Oliver Hader 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Benni Mack 3 months ago

  • Status changed from Resolved to Closed

#11 Updated by Oliver Hader 3 months ago

  • Related to Bug #91171: Renaming folder or file in filelist module throws PHP warning added

Also available in: Atom PDF