Project

General

Profile

Actions

Bug #99402

closed

Unnecessary quote in the file list

Added by Dmitry Dulepov almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Start date:
2022-12-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

TYPO3\CMS\Filelist\FileList::makeRef() contains the following code:

        return '
            <button ' . GeneralUtility::implodeAttributes($attributes, true) . '">

There is an unnecessary quote. It produces html as follows:

<button type="button" class="btn btn-link p-0" data-filelist-show-item-type="_FILE" 
 data-filelist-show-item-identifier="1:/user_upload/easyweb/fotogalerie_hund3.jpg" 
 title="Show references (31)"">

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #91016: Reduce inline JavaScript in ext:filelistClosedOliver Hader2020-04-13

Actions
Actions #1

Updated by Georg Ringer almost 2 years ago

  • Related to Task #91016: Reduce inline JavaScript in ext:filelist added
Actions #2

Updated by Georg Ringer almost 2 years ago

  • Status changed from New to Accepted
  • Target version set to Candidate for patchlevel
Actions #3

Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77199

Actions #4

Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77199

Actions #5

Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77216

Actions #6

Updated by Georg Ringer almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77201

Actions #8

Updated by Georg Ringer almost 2 years ago

  • Status changed from Under Review to Resolved
Actions #9

Updated by Benni Mack almost 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF